Skip to content

Reduce repeated date configuration resolution - #315

Merged
andrey-helldar merged 2 commits into
mainfrom
fix/310-date-config-resolution
Oct 14, 2026
Merged

andrey-helldar merged 2 commits into
mainfrom
fix/310-date-config-resolution

Conversation

@andrey-helldar

@andrey-helldar andrey-helldar commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

What:

  • Bug Fix
  • New Feature

Description:

Date transformations resolve the configuration service separately for the timezone and format. Lazily reuse the repository within each transformation to reduce two resolutions to one while retaining live settings, replacement bindings, and subclass hooks. Restore the previous state after failures and nested transformations. Keep the cache fields and repository helper private so existing subclasses can use the same names with unrelated types.

Validation:

  • 520 tests passed with 4575 assertions, including existing DateFormat, inheritance, transformer-order coverage, and three independently reproduced subclass-member collision regressions.
  • Pint and git diff --check passed.
  • Published benchmark outputs matched byte for byte across XML, JSON, JSONL, CSV, and RSS; input dates and model attributes remained unchanged.
  • Before the visibility-only compatibility fix, the isolated probe's median decreased by about 3% over nine alternating samples. Timing ranges overlap, so these measurements do not establish a general feed-generation speedup.
  • Type coverage was unavailable because the installed Pest did not recognize --type-coverage.

Related:

Closes #310

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T18:48:07.325180Z e5d2af0 New commits
🔒 Security Review ✅ Completed 2026-10-14T17:03:36.260281Z 2387c9f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@andrey-helldar andrey-helldar added the fix Functionality or something fix label Oct 14, 2026 — with ChatGPT Codex Connector

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2387c9fac2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Transformers/DateTimeTransformer.php Outdated
@andrey-helldar
andrey-helldar merged commit 40f1a0e into main Oct 14, 2026
19 checks passed
@andrey-helldar
andrey-helldar deleted the fix/310-date-config-resolution branch October 14, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Functionality or something fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce repeated configuration service resolution in date transformation

1 participant