Skip to content

RFC: Encode zero kind_id semantic in return type #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
foxidokun wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RFC: Encode zero kind_id semantic in return type #689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/attributes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ use llvm_sys::core::{LLVMGetTypeAttributeValue, LLVMIsTypeAttribute};
use llvm_sys::prelude::LLVMAttributeRef;

use std::ffi::CStr;
use std::num::NonZeroU32;

#[llvm_versions(12..)]
use crate::types::AnyTypeEnum;
Expand Down Expand Up @@ -170,14 +171,16 @@ impl Attribute {
/// use inkwell::attributes::Attribute;
///
/// // This kind id doesn't exist:
/// assert_eq!(Attribute::get_named_enum_kind_id("foobar"), 0);
/// assert_eq!(Attribute::get_named_enum_kind_id("foobar"), None);
///
/// // These are real kind ids:
/// assert_eq!(Attribute::get_named_enum_kind_id("align"), 1);
/// assert_eq!(Attribute::get_named_enum_kind_id("builtin"), 5);
/// assert_eq!(Attribute::get_named_enum_kind_id("align").unwrap().get(), 1);
/// assert_eq!(Attribute::get_named_enum_kind_id("builtin").unwrap().get(), 5);
/// ```
pub fn get_named_enum_kind_id(name: &str) -> u32 {
unsafe { LLVMGetEnumAttributeKindForName(name.as_ptr() as *const ::libc::c_char, name.len()) }
pub fn get_named_enum_kind_id(name: &str) -> Option<NonZeroU32> {
let id = unsafe { LLVMGetEnumAttributeKindForName(name.as_ptr() as *const ::libc::c_char, name.len()) };

NonZeroU32::new(id)
}

/// Gets the kind id associated with an enum `Attribute`.
Expand Down
Loading