Skip to content

Reduce bezel redraw work and release CGColors #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emanuelst wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Reduce bezel redraw work and release CGColors #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2da5e78
Cache bezel background rendering
emanuelst Aug 4, 2026
1c0fcb9
Release CGColor objects after layer assignment
emanuelst Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions UI/BezelWindow.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@
NSImageView *iconView;
id<BezelWindowDelegate> delegate;
Boolean color;
NSColor *backgroundColorCache;
NSSize backgroundColorCacheSize;
float backgroundColorCacheAlpha;
Boolean backgroundColorCacheColor;
}

- (id)initWithContentRect:(NSRect)contentRect
Expand Down
55 changes: 45 additions & 10 deletions UI/BezelWindow.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,18 @@ - (id)initWithContentRect:(NSRect)contentRect
[[self contentView] addSubview:sourceFieldBackground];
[sourceFieldBackground.textField setEditable:NO];
[sourceFieldBackground.textField setTextColor:[NSColor whiteColor]];
[sourceFieldBackground.background.layer setBackgroundColor:CGColorCreateGenericRGB(0.1, 0.1, 0.1, 0.45)];
CGColorRef sourceBackgroundColor = CGColorCreateGenericRGB(0.1, 0.1, 0.1, 0.45);
[sourceFieldBackground.background.layer setBackgroundColor:sourceBackgroundColor];
CGColorRelease(sourceBackgroundColor);
[sourceFieldBackground.textField setBordered:NO];

sourceFieldApp = [[RoundRecTextField alloc] initWithFrame:[self sourceFrameLeft]];
[[self contentView] addSubview:sourceFieldApp];
[sourceFieldApp.textField setEditable:NO];
[sourceFieldApp.textField setTextColor:[NSColor whiteColor]];
[sourceFieldApp.background.layer setBackgroundColor:CGColorCreateGenericRGB(0.1, 0.1, 0.1, 0.0)];
CGColorRef sourceAppColor = CGColorCreateGenericRGB(0.1, 0.1, 0.1, 0.0);
[sourceFieldApp.background.layer setBackgroundColor:sourceAppColor];
CGColorRelease(sourceAppColor);
[sourceFieldApp.textField setBordered:NO];
[sourceFieldApp.textField setAlignment:NSLeftTextAlignment];

Expand All @@ -77,7 +81,9 @@ - (id)initWithContentRect:(NSRect)contentRect
[[self contentView] addSubview:sourceFieldDate];
[sourceFieldDate.textField setEditable:NO];
[sourceFieldDate.textField setTextColor:[NSColor whiteColor]];
[sourceFieldDate.background.layer setBackgroundColor:CGColorCreateGenericRGB(0.1, 0.1, 0.1, 0.0)];
CGColorRef sourceDateColor = CGColorCreateGenericRGB(0.1, 0.1, 0.1, 0.0);
[sourceFieldDate.background.layer setBackgroundColor:sourceDateColor];
CGColorRelease(sourceDateColor);
[sourceFieldDate.textField setBordered:NO];
[sourceFieldDate.textField setAlignment:NSRightTextAlignment];
font = [sourceFieldDate.textField font];
Expand All @@ -92,7 +98,9 @@ - (id)initWithContentRect:(NSRect)contentRect
//[[textField cell] setScrollable:YES];
//[[textField cell] setWraps:NO];
[textField.textField setTextColor:[NSColor whiteColor]];
[textField.background.layer setBackgroundColor:CGColorCreateGenericRGB(0.1, 0.1, 0.1, 0.45)];
CGColorRef textFieldColor = CGColorCreateGenericRGB(0.1, 0.1, 0.1, 0.45);
[textField.background.layer setBackgroundColor:textFieldColor];
CGColorRelease(textFieldColor);
[textField.textField setBordered:NO];
[textField.textField setAlignment:NSLeftTextAlignment];

Expand All @@ -101,7 +109,9 @@ - (id)initWithContentRect:(NSRect)contentRect
[[self contentView] addSubview:charField];
[charField.textField setEditable:NO];
[charField.textField setTextColor:[NSColor whiteColor]];
[charField.background.layer setBackgroundColor:CGColorCreateGenericRGB(0.1, 0.1, 0.1, 0.45)];
CGColorRef charFieldColor = CGColorCreateGenericRGB(0.1, 0.1, 0.1, 0.45);
[charField.background.layer setBackgroundColor:charFieldColor];
CGColorRelease(charFieldColor);
[charField.textField setBordered:NO];
[charField.textField setAlignment:NSCenterTextAlignment];
[charField.textField setStringValue:@"Empty"];
Expand Down Expand Up @@ -132,10 +142,16 @@ - (void) update {
[textField setFrame:textFrame];
NSRect charFrame = [self charFrame];
[charField setFrame:charFrame];
if (showSourceField)
[sourceFieldBackground.background.layer setBackgroundColor:CGColorCreateGenericRGB(0.1, 0.1, 0.1, 0.45)];
else if ( nil != sourceFieldApp )
[sourceFieldBackground.background.layer setBackgroundColor:CGColorCreateGenericRGB(0.1, 0.1, 0.1, 0.0)];
if (showSourceField) {
CGColorRef sourceBackgroundColor = CGColorCreateGenericRGB(0.1, 0.1, 0.1, 0.45);
[sourceFieldBackground.background.layer setBackgroundColor:sourceBackgroundColor];
CGColorRelease(sourceBackgroundColor);
}
else if ( nil != sourceFieldApp ) {
CGColorRef sourceBackgroundColor = CGColorCreateGenericRGB(0.1, 0.1, 0.1, 0.0);
[sourceFieldBackground.background.layer setBackgroundColor:sourceBackgroundColor];
CGColorRelease(sourceBackgroundColor);
}

showSourceField = savedShowSourceField;

Expand Down Expand Up @@ -190,7 +206,25 @@ -(NSRect) charFrame

-(NSColor*) backgroundColor
{
return [self sizedBezelBackgroundWithRadius:25.0 withAlpha:[[NSUserDefaults standardUserDefaults] floatForKey:@"bezelAlpha"]];
NSSize backgroundSize = [self frame].size;
float backgroundAlpha = [[NSUserDefaults standardUserDefaults] floatForKey:@"bezelAlpha"];

// AppKit may call -update frequently on modern macOS. Rebuilding the
// bitmap pattern on every update is unnecessarily expensive and can keep
// the main thread busy while the bezel is idle. Rebuild only when one of
// the inputs that affects the background has changed.
if (backgroundColorCache != nil
&& NSEqualSizes(backgroundColorCacheSize, backgroundSize)
&& backgroundColorCacheAlpha == backgroundAlpha
&& backgroundColorCacheColor == color)
return backgroundColorCache;

[backgroundColorCache release];
backgroundColorCache = [[self sizedBezelBackgroundWithRadius:25.0 withAlpha:backgroundAlpha] retain];
backgroundColorCacheSize = backgroundSize;
backgroundColorCacheAlpha = backgroundAlpha;
backgroundColorCacheColor = color;
return backgroundColorCache;
}

- (void) setAlpha:(float)newValue
Expand Down Expand Up @@ -314,6 +348,7 @@ -(BOOL)canBecomeKeyWindow

- (void)dealloc
{
[backgroundColorCache release];
[textField release];
[charField release];
[iconView release];
Expand Down