Repository navigation
fix(dry-run): restore stats and recall previews with inferred credits - #977
Conversation
|
No findings. The PR description documents sufficient testing, including a representative real-CLI end-to-end verification. I did not run or build the PR, per instructions. |
d3fc4c5 to
a39700a
Compare
|
No findings. The PR description documents sufficient testing, including representative real-CLI end-to-end verification on the original head. Per the review rules, referencing an older commit is not blocking. The earlier review also had no findings. I only read the specified diff and surrounding code; I did not run, build, or install anything from the PR. |
|
@jeff-r2026 This PR fixes the CI issue with |
Summary
Follow-up to merged #970. Legacy sessions split across scopes reuse their already-reported credit. Missing baseline snapshots reuse the same owners without creating the owners file during preview.
Rebased onto
mainat34f32f03. Resolved conflicts in the guard, refusal tests and both usage guides while preserving the Git previews and import-source precedence merged in #971. Removed obsolete merge-order notes from the guides. The five non-conflicting PR files are byte-for-byte unchanged from the original head.Evidence
Current rebased head
a39700a6:npx vitest run src/__tests__/dry-run-guard.test.ts src/__tests__/stats-scope.test.ts src/__tests__/stats-foreign-reports.test.ts src/__tests__/dashboard-report-scope.test.ts src/__tests__/team-push-interventions.test.ts src/__tests__/reports-readers-busy.test.ts src/__tests__/reports-reader-lock.test.ts: 130 tests passed across seven files.npx tsc --noEmit,npm run lint,npm run build, andgit diff --check origin/main..HEADpassed.git range-diffconfirms that changes from the original PR commit are limited to conflict integration. The guard differs from current main only in the two stats/recall classifications. Its tests cover both fix(dry-run): git previews for remove, roles/projects and import --from-repo (#900) #971 Git previews and fix(dry-run): restore stats and recall previews with inferred credits #977 stats/recall previews.Original-head verification at
d3fc4c5c:session-owners.jsonlduring preview.python3 /tmp/teamai-900/C-sol-round3-realcli.py "$PWD/dist/index.js"passed. Preview and real stats both showed 1 session / 6 turns. Recall preview returnedDeployment timeout fix. The 121-file fixture SHA256 stayed9acfcb0ee2f22beaaacb01ee6bedf19e2ccda204a53dae2aa0a99ad13cac8c54across both previews. Owners/index/sessions remained absent, and config bytes stayed identical after real stats. Real stats still seeded owners without a dry-run notice; explicit preview retained its migration notice.Merge Danger
Door: two-way
Blast Radius: stats
No storage format change or global cache. Owner/credit state belongs to one stats invocation. Scope filtering and baseline/credit readers consume it without changing it. Real stats retains owner seeding; reporting callers retain disk-backed defaults and persist-gated snapshot writes.
The whole branch diff and shared-state readers/writers were reviewed. Preview reads the reports checkout without refreshing it, so totals can differ from real stats when remote reports changed. Extra provider/agent coverage remains CI work.
Related Issues
Refs #900 (C6, C9 follow-up)
Refs #972
Addresses the remaining #970 review. Both usage guides are updated. No affected refusal wording remains in skill-data or designs; help and command-reference generation are unchanged.