Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3512. This is an independent PR adding Amazon Bedrock Agent Runtime reranking (not Bedrock Runtime chat APIs).
What changed
amazon.rerank-v1:0andcohere.rerank-v3-5:0.bedrockagentruntime.Rerankaction with per-model AWS Access Key ID / Secret Access Key, regional SigV4 signing, and the existing SSRF-safe HTTP transport.Credentials / scope
This implementation supports static AWS AK/SK pairs only. Temporary credentials with a session token, IAM role chains and ADC-style host credentials are intentionally not used, to avoid cross-tenant credential fallback. The model secret uses the existing
AppSecretstorage path; encryption at rest requires the deployment'sSYSTEM_AES_KEYconfiguration. AWS-side permissions/model access are still required. No live AWS account was available for end-to-end verification.Validation
go test ./internal/models/api/bedrockrank ./internal/models/rerank ./internal/models/providers— passpython3 scripts/model-catalog/generate.py --check— passgit diff --check— passThe full parity suite is not runnable in this environment because its unrelated vendor-host SSRF tests require DNS resolution to public endpoints. The full handler suite has an existing unrelated failure in
TestPutTenantParserConfigAdminPreservesRedactedSecrets(expected 200, got 400); the Bedrock-specific handler tests pass.