Repository navigation
fix(wiki): resolve titles for unloaded backlinks - #3931
Open
hahahahahayesyeseys wants to merge 1 commit into
Open
hahahahahayesyeseys wants to merge 1 commit into
hahahahahayesyeseys wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wiki backlink labels were rendered from the slug whenever the target page had not yet been loaded into the paginated sidebar. This made concept and entity backlinks display identifiers instead of their page titles.
This change:
GET /api/v1/knowledgebase/:kb_id/wiki/page-titles, backed by the existing lightweightListBySlugsquery;The endpoint uses
/wiki/page-titlesbecause Gin's existing/wiki/pages/*slugcatch-all route cannot coexist with a/wiki/pages/titlesstatic route.Type of Change
Related Issue
Fixes #3922
Testing
GOTOOLCHAIN=local /tmp/go1.26.1/bin/go test ./internal/handler ./internal/router -count=1npm test -- src/views/knowledge/wiki/wikiBacklinkTitles.test.ts src/views/knowledge/wiki/wikiDirectoryState.test.tsnpm run type-checkgit diff --check origin/main...HEADAll focused checks passed. The full frontend suite was also attempted: 1,358 passed, 7 failed, 1 skipped out of 1,366. The failures were environment-related Vite/MCP proxy and file-watcher-limit errors. The full backend repository suite was not run.
Checklist
git diff --check origin/main...HEADpassesgolangci-lintis unavailable in the environment)website-docs/and Swagger annotations)Screenshots / Recordings
The fix changes backlink text rendering in the Wiki browser. No authenticated live UI instance was available for a screenshot in this environment; the rendering logic is covered by
wikiBacklinkTitles.test.ts.