Repository navigation
mt76: mt7996: fix station tx rate reported to mac80211 - #1328
Open
hehuimin-cybertan wants to merge 1 commit into
Open
hehuimin-cybertan wants to merge 1 commit into
hehuimin-cybertan wants to merge 1 commit into
Conversation
wcid->rate is taken from the last TXS and passed to mac80211 with every tx status. Only frames that request a tx status get a TXS, and most of those (mgmt, EAPOL, nullfunc) are sent at the fixed basic rate, so on 2.4 GHz wcid->rate often becomes OFDM 6 Mbps for an HE station. mac80211 stores it in last_rate_info and uses it to estimate the airtime of every queued frame for AQL. With a legacy rate the estimate is the full non-aggregated 6 Mbps airtime, so AQL allows only a few frames in flight and downlink TCP drops from ~200 Mbps to ~50-80 Mbps until a data frame TXS happens to restore an HE rate. - Skip legacy-rate TXS when updating the rate of an HT/HE/EHT station. - Take the whole TX rate (mode, bw, mcs, nss, gi) from the periodic UNI_ALL_STA_TXRX_RATE firmware report instead of only the GI, so wcid->rate follows the firmware rate control. The rate conversion is taken from mt7996_mcu_update_rate() in the MediaTek SDK patch "mtk: mt76: rework statistics report for mt7996" (0044), TX part only, with HE MCS limited to 11 as in the TXS path. Fixes: WIFI-15762 Signed-off-by: huimin.he <huimin.he@cybertan.com.tw>
✅ PR & Commit Guidelines — all checks passedCommits, PR description, C style, and milestone all look good. Thanks! Commit hygieneNo issues found. C styleNo issues found. PR description (ticket link)No issues found. MilestoneNo issues found. See OPENWIFI_PR_GUIDELINES.md and OPENWIFI_CODING_GUIDELINES.md. Items marked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wcid->rate is taken from the last TXS and passed to mac80211 with every tx status. Only frames that request a tx status get a TXS, and most of those (mgmt, EAPOL, nullfunc) are sent at the fixed basic rate, so on 2.4 GHz wcid->rate often becomes OFDM 6 Mbps for an HE station.
mac80211 stores it in last_rate_info and uses it to estimate the airtime of every queued frame for AQL. With a legacy rate the estimate is the full non-aggregated 6 Mbps airtime, so AQL allows only a few frames in flight and downlink TCP drops from ~200 Mbps to ~50-80 Mbps until a data frame TXS happens to restore an HE rate.
Fixes: WIFI-15762