Skip to content

Enhance/UI ux better error feedback when editing bookmarks in settings - #4687

Open
alihrhera wants to merge 2 commits into
TeamAmaze:release/4.0from
alihrhera:enhance/ui-ux-better-error-feedback-when-editing-bookmarks-in-settings
Open

Enhance/UI ux better error feedback when editing bookmarks in settings#4687
alihrhera wants to merge 2 commits into
TeamAmaze:release/4.0from
alihrhera:enhance/ui-ux-better-error-feedback-when-editing-bookmarks-in-settings

Refactor bookmark preference fragments for improved code style and fo…

4d85d04
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Jul 25, 2026 in 0s

5 new issues (0 max.) of at least severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 5
           

Complexity increasing per file
==============================
- app/src/main/java/com/amaze/filemanager/ui/fragments/preferencefragments/BookmarkPrefsViewModel.kt  14
         

Complexity decreasing per file
==============================
+ app/src/main/java/com/amaze/filemanager/ui/fragments/preferencefragments/BookmarksPrefsFragment.kt  -3
         

See the complete overview on Codacy

Annotations

Check notice on line 17 in app/src/main/java/com/amaze/filemanager/ui/fragments/preferencefragments/BookmarkPrefsViewModel.kt

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/src/main/java/com/amaze/filemanager/ui/fragments/preferencefragments/BookmarkPrefsViewModel.kt#L17

The function isValidBookmarkPath is missing documentation.

Check notice on line 54 in app/src/main/java/com/amaze/filemanager/ui/fragments/preferencefragments/BookmarkPrefsViewModel.kt

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/src/main/java/com/amaze/filemanager/ui/fragments/preferencefragments/BookmarkPrefsViewModel.kt#L54

The function isValidBookmarkName is missing documentation.

Check notice on line 66 in app/src/main/java/com/amaze/filemanager/ui/fragments/preferencefragments/BookmarkPrefsViewModel.kt

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/src/main/java/com/amaze/filemanager/ui/fragments/preferencefragments/BookmarkPrefsViewModel.kt#L66

The function isValidBookmark is missing documentation.

Check warning on line 114 in app/src/main/java/com/amaze/filemanager/ui/fragments/preferencefragments/BookmarksPrefsFragment.kt

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/src/main/java/com/amaze/filemanager/ui/fragments/preferencefragments/BookmarksPrefsFragment.kt#L114

The function showBookmarkDialog is too long (68). The maximum length is 60.

Check warning on line 183 in app/src/main/java/com/amaze/filemanager/ui/fragments/preferencefragments/BookmarksPrefsFragment.kt

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/src/main/java/com/amaze/filemanager/ui/fragments/preferencefragments/BookmarksPrefsFragment.kt#L183

Expression with labels increase complexity and affect maintainability.