perf(start-client-core): compact private frame decoder result keys - #7978
perf(start-client-core): compact private frame decoder result keys#7978Sheraff wants to merge 3 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit b0c4ab1
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version Preview5 package(s) bumped directly, 18 bumped as dependents. 🟩 Patch bumps
|
Bundle Size Benchmarks
The following scenarios have bundle-size changes compared with the baseline:
Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better. |
Merging this PR will regress 4 benchmarks
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | mem server server-fn-churn (solid) |
269.8 KB | 3,683.3 KB | -92.68% |
| ❌ | Memory | mem server error-paths not-found (solid) |
415.1 KB | 784.7 KB | -47.1% |
| ❌ | Simulation | ssr server-fn during document ssr (react) |
62.9 ms | 66.2 ms | -5.05% |
| ❌ | Memory | mem server error-paths not-found (react) |
277.7 KB | 286.9 KB | -3.23% |
| ⚡ | Memory | mem server server-fn-churn (vue) |
4,147.3 KB | 275.8 KB | ×15 |
| ⚡ | Memory | mem server error-paths unmatched (vue) |
2,142.1 KB | 479 KB | ×4.5 |
| ⚡ | Memory | mem server peak-large-page (react) |
1,737.5 KB | 952.1 KB | +82.49% |
| ⚡ | Memory | mem server error-paths redirect (solid) |
388 KB | 283.5 KB | +36.87% |
| ⚡ | Memory | mem server error-paths redirect (vue) |
338.6 KB | 294.7 KB | +14.89% |
| ⚡ | Memory | mem server error-paths unmatched (react) |
317.5 KB | 296 KB | +7.27% |
| ⚡ | Memory | mem client navigation-churn (vue) |
1.3 MB | 1.2 MB | +3.62% |
| ⚡ | Memory | mem client navigation-churn (solid) |
580.3 KB | 560.9 KB | +3.44% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing codex/frame-decoder-compact-result (b0c4ab1) with main (697ebb6)
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud has identified a possible root cause for your failed CI:
We classified this failure as an environment issue rather than a code change. The test failed with EADDRINUSE on port 32915, meaning another process had already claimed that port before the test's external server could start — unrelated to the PR's internal key renames in @tanstack/start-client-core. No port configuration or test infrastructure was modified by this PR.
No code changes were suggested for this issue.
Trigger a rerun:
🎓 Learn more about Self-Healing CI on nx.dev
What changed
Bundle impact
Across the full 17-scenario matrix, all 11 Start scenarios improve by 4–12 B gzip and 24 B raw; all six router-only scenarios are byte-identical. Both renames also improve independently on react-start.minimal: getStream saves 6 B gzip / 16 B raw, and chunks saves 1 B gzip / 8 B raw. Brotli is mixed and documented in the evidence report.
Validation
Detailed artifacts and attribution are recorded in RESULT-optimization-frame-decoder-compact-result.md.