Skip to content

perf(router-core): fuse dynamic route node construction - #7974

Closed
Sheraff wants to merge 4 commits into
mainfrom
codex/fuse-dynamic-route-nodes
Closed

perf(router-core): fuse dynamic route node construction#7974
Sheraff wants to merge 4 commits into
mainfrom
codex/fuse-dynamic-route-nodes

Conversation

@Sheraff

@Sheraff Sheraff commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • records dynamic sibling arrays once, when they first need sorting, instead of recursively walking the completed trie
  • reuses the parsed route path/options within parseSegments
  • shares required, optional, and wildcard node-construction logic while preserving optional/required reuse and one-node-per-wildcard-route behavior
  • adds focused correctness coverage and a route-tree construction benchmark

Bundle size

react-router.minimal:

Metric Before After Change
gzip 89,200 B 89,145 B -55 B
initial gzip 89,058 B 89,004 B -54 B
raw 275,591 B 274,715 B -876 B
Brotli 77,742 B 77,571 B -171 B

All 17 scenarios improve by 55–125 B gzip and 870–904 B raw. Brotli is mixed: -180 to +83 B, with 6 small regressions.

Hunk attribution on the minimal scenario: sparse sorting -16 B isolated, cached fields -1 B isolated, first two together -19 B, fused construction -36 B incremental.

Runtime

Across three construction-benchmark runs, the complete group is approximately 2–9% faster than baseline over static, dense-dynamic, reused-shape, and route-mask inputs. Fusion alone is a small construction slowdown (+0.5% to +3.2% in cumulative medians), offset by the sparse-sort and cached-read changes; it is included for bundle size, not claimed as an independent runtime win.

The full measurements and methodology are in RESULT-optimization-fused-route-nodes.md.

Validation

  • router-core unit: 1,529 passed, 3 expected failures
  • router-core type tests: all configured TypeScript versions
  • router-core ESLint: no errors
  • React Router generator CLI e2e: 3 passed
  • full 17-scenario bundle matrix
  • five independent implementation/test/performance reviews

Summary by CodeRabbit

  • Bug Fixes

    • Improved route matching when required, optional, and wildcard routes compete.
    • Preserved correct parser priority and parameter extraction across complex route patterns.
    • Improved handling of wildcard aliases and reused dynamic route segments.
    • Corrected route-mask ordering and matching for prefix, suffix, parameter, and wildcard patterns.
  • Performance

    • Reduced route-tree construction overhead and bundle size across tested scenarios.
    • Improved construction efficiency for dense, reused, and masked route configurations.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 841aa55c-5817-463a-8a1b-2573ddee9eec

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and c4597ae.

📒 Files selected for processing (4)
  • RESULT-optimization-fused-route-nodes.md
  • packages/router-core/src/new-process-route-tree.ts
  • packages/router-core/tests/new-process-route-tree.test.ts
  • packages/router-core/tests/route-tree-construction.bench.ts

📝 Walkthrough

Walkthrough

Changes

Route-node construction optimization

Layer / File(s) Summary
Fused route construction
packages/router-core/src/new-process-route-tree.ts
Route parsing uses resolved paths and local options. Dynamic, optional, and wildcard segments share construction logic. Compatible parameter nodes can be reused, wildcard aliases remain separate, and collected sibling lists are sorted after parsing.
Route and mask matching validation
packages/router-core/tests/new-process-route-tree.test.ts
Tests cover priority fallback, optional-node reuse, wildcard aliases, and specificity for route-mask patterns.
Construction benchmarks and results
packages/router-core/tests/route-tree-construction.bench.ts, RESULT-optimization-fused-route-nodes.md
Benchmarks cover four route-tree workloads. The report records construction timings, bundle-size results, correctness coverage, and validation results.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant RouteTreeProcessing
  participant parseSegments
  participant DynamicSiblingLists
  RouteTreeProcessing->>parseSegments: parse routes and collect dynamic lists
  parseSegments->>DynamicSiblingLists: register lists with multiple entries
  RouteTreeProcessing->>DynamicSiblingLists: sort collected lists after parsing
Loading

Possibly related PRs

  • TanStack/router#7969: Extends the route-tree sibling-sorting optimization in the same parser and processing flow.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main performance change in router-core.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fuse-dynamic-route-nodes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 01aaec5

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 9m 11s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 1s View ↗

☁️ Nx Cloud last updated this comment at 2026-08-06 10:42:40 UTC

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/react-router 1.170.20 → 1.170.21 Changeset
@tanstack/router-core 1.171.17 → 1.171.18 Changeset
@tanstack/solid-router 1.170.20 → 1.170.21 Changeset
@tanstack/start-server-core 1.169.20 → 1.169.21 Changeset
@tanstack/vue-router 1.170.19 → 1.170.20 Changeset
@tanstack/react-start 1.168.37 → 1.168.38 Dependent
@tanstack/react-start-client 1.168.18 → 1.168.19 Dependent
@tanstack/react-start-rsc 0.1.36 → 0.1.37 Dependent
@tanstack/react-start-server 1.167.25 → 1.167.26 Dependent
@tanstack/router-cli 1.167.23 → 1.167.24 Dependent
@tanstack/router-generator 1.167.23 → 1.167.24 Dependent
@tanstack/router-plugin 1.168.25 → 1.168.26 Dependent
@tanstack/router-vite-plugin 1.167.25 → 1.167.26 Dependent
@tanstack/solid-start 1.168.36 → 1.168.37 Dependent
@tanstack/solid-start-client 1.168.18 → 1.168.19 Dependent
@tanstack/solid-start-server 1.167.25 → 1.167.26 Dependent
@tanstack/start-client-core 1.170.16 → 1.170.17 Dependent
@tanstack/start-plugin-core 1.171.28 → 1.171.29 Dependent
@tanstack/start-static-server-functions 1.167.21 → 1.167.22 Dependent
@tanstack/start-storage-context 1.167.19 → 1.167.20 Dependent
@tanstack/vue-start 1.168.35 → 1.168.36 Dependent
@tanstack/vue-start-client 1.167.21 → 1.167.22 Dependent
@tanstack/vue-start-server 1.167.25 → 1.167.26 Dependent

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 8ceb150ce367
  • Measured at: 2026-08-06T10:32:42.247Z
  • Baseline source: history:697ebb6ddbd4
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

Scenario Current (gzip) Delta vs baseline Initial gzip Raw Brotli Trend
react-router.minimal 87.06 KiB -55 B (-0.06%) 86.92 KiB 268.28 KiB 75.75 KiB ████▂▂▂▂▂▂▂▁
react-router.full 90.81 KiB -88 B (-0.09%) 90.68 KiB 280.24 KiB 79.08 KiB ████▄▄▄▄▄▃▃▁
solid-router.minimal 34.74 KiB -58 B (-0.16%) 34.61 KiB 99.10 KiB 31.42 KiB ████▂▂▂▂▂▂▂▁
solid-router.full 39.83 KiB -72 B (-0.18%) 39.70 KiB 114.27 KiB 35.82 KiB ████▂▂▂▂▂▂▂▁
vue-router.minimal 52.03 KiB -69 B (-0.13%) 51.90 KiB 142.25 KiB 46.84 KiB ████▂▂▂▂▂▁▁▁
vue-router.full 57.95 KiB -100 B (-0.17%) 57.82 KiB 160.92 KiB 52.08 KiB ████▂▂▂▂▂▂▂▁
react-start.minimal 100.50 KiB -104 B (-0.10%) 100.36 KiB 311.42 KiB 87.23 KiB ███████▂▂▁▁▁
react-start.deferred-hydration 101.23 KiB -106 B (-0.10%) 100.38 KiB 312.79 KiB 87.89 KiB ███████▂▂▁▁▁
react-start.full 103.86 KiB -60 B (-0.06%) 103.73 KiB 321.37 KiB 90.24 KiB ███████▁▁▁▁▁
react-start.rsbuild.minimal 100.12 KiB -118 B (-0.11%) 99.95 KiB 315.90 KiB 86.31 KiB ▁▁▁▁▂▂▂████▆
react-start.rsbuild.minimal-iife 100.53 KiB -118 B (-0.11%) 100.36 KiB 316.84 KiB 86.73 KiB ▁▁▁▁▂▂▂████▆
react-start.rsbuild.full 103.45 KiB -125 B (-0.12%) 103.28 KiB 326.00 KiB 89.06 KiB ▁▁▁▁▃▃▃████▇
solid-start.minimal 48.10 KiB -84 B (-0.17%) 47.97 KiB 141.24 KiB 42.83 KiB ███████▂▂▁▁▁
solid-start.deferred-hydration 51.36 KiB -82 B (-0.16%) 48.03 KiB 149.28 KiB 45.75 KiB ███████▂▂▁▁▁
solid-start.full 53.36 KiB -77 B (-0.14%) 53.23 KiB 156.97 KiB 47.39 KiB ████▆▆▆▁▁▁▁▁
vue-start.minimal 68.87 KiB -104 B (-0.15%) 68.74 KiB 194.25 KiB 61.31 KiB ████▆▆▆▁▁▁▁▁
vue-start.full 72.86 KiB -76 B (-0.10%) 72.73 KiB 206.75 KiB 64.78 KiB ████▆▆▆▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-new Bot commented Aug 6, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7974

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7974

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7974

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7974

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7974

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7974

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7974

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7974

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7974

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7974

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7974

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7974

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7974

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7974

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7974

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7974

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7974

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7974

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7974

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7974

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7974

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7974

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7974

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7974

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7974

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7974

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7974

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7974

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7974

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7974

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7974

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7974

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7974

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7974

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7974

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7974

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7974

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7974

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7974

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7974

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7974

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7974

commit: 01aaec5

@codspeed-hq

codspeed-hq Bot commented Aug 6, 2026

Copy link
Copy Markdown

Merging this PR will regress 5 benchmarks

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 7 improved benchmarks
❌ 5 regressed benchmarks
✅ 168 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory mem server error-paths not-found (solid) 415.1 KB 759.7 KB -45.36%
Memory mem client preload-churn (vue) 737 KB 780.6 KB -5.59%
Simulation ssr server-fn during document ssr (react) 62.9 ms 66 ms -4.68%
Memory mem server error-paths redirect (react) 197 KB 204.2 KB -3.55%
Simulation ssr control-flow error 500 (react) 60.4 ms 62.4 ms -3.18%
Memory mem server server-fn-churn (vue) 4,147.3 KB 263.1 KB ×16
Memory mem server error-paths unmatched (vue) 2,142.1 KB 480.7 KB ×4.5
Memory mem server peak-large-page (react) 1,737.5 KB 951.2 KB +82.66%
Memory mem server error-paths redirect (solid) 388 KB 272.3 KB +42.5%
Memory mem server error-paths redirect (vue) 338.6 KB 289.7 KB +16.87%
Memory mem server error-paths not-found (react) 277.7 KB 256 KB +8.45%
Memory mem client navigation-churn (vue) 1.3 MB 1.2 MB +4.44%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fuse-dynamic-route-nodes (01aaec5) with main (697ebb6)

Open in CodSpeed

@Sheraff
Sheraff marked this pull request as ready for review August 6, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant