fix(router-core): properly handle serialization of readonly maps/sets at type level

.changeset/full-flowers-carry.md

@@ -0,0 +1,5 @@
+---
+'@tanstack/router-core': patch
+---
+
+fix(router-core): properly handle serialization of readonly maps/sets at type level

packages/router-core/src/ssr/serializer/transformer.ts

@@ -86,10 +86,10 @@ export type ValidateSerializable<T, TSerializable> = T extends TSerializable
           ? ValidateSerializablePromise<T, TSerializable>
           : T extends ReadableStream<any>
             ? ValidateReadableStream<T, TSerializable>
-            : T extends Set<any>
-              ? ValidateSerializableSet<T, TSerializable>
-              : T extends Map<any, any>
-                ? ValidateSerializableMap<T, TSerializable>
+            : T extends ReadonlyMap<any, any>
+              ? ValidateSerializableMap<T, TSerializable>
+              : T extends ReadonlySet<any>
+                ? ValidateSerializableSet<T, TSerializable>
                 : T extends AsyncGenerator<any, any>
                   ? ValidateSerializableAsyncGenerator<T, TSerializable>
                   : T extends object
@@ -118,15 +118,22 @@ export type ValidateReadableStream<T, TSerializable> =
 export type ValidateSerializableSet<T, TSerializable> =
   T extends Set<infer TItem>
     ? Set<ValidateSerializable<TItem, TSerializable>>
-    : never
+    : T extends ReadonlySet<infer TItem>
+      ? ReadonlySet<ValidateSerializable<TItem, TSerializable>>
+      : never
 
 export type ValidateSerializableMap<T, TSerializable> =
   T extends Map<infer TKey, infer TValue>
     ? Map<
         ValidateSerializable<TKey, TSerializable>,
         ValidateSerializable<TValue, TSerializable>
       >
-    : never
+    : T extends ReadonlyMap<infer TKey, infer TValue>
+      ? ReadonlyMap<
+          ValidateSerializable<TKey, TSerializable>,
+          ValidateSerializable<TValue, TSerializable>
+        >
+      : never
 
 export type ValidateSerializableArray<T, TSerializable> = T extends readonly [
   any,

packages/router-core/tests/serializer.test-d.ts

@@ -21,4 +21,39 @@ describe('Serializer', () => {
       ValidateSerializable<MyCustomType, Serializable>
     >().toEqualTypeOf<MyCustomType>()
   })
+
+  it('works for readonly sets containing serializable values', () => {
+    type Value = ReadonlySet<string>
+
+    expectTypeOf<
+      ValidateSerializable<Value, Serializable>
+    >().toEqualTypeOf<Value>()
+  })
+
+  it('fails for readonly sets containing unserializable values', () => {
+    type Value = ReadonlySet<() => void>
+
+    expectTypeOf<ValidateSerializable<Value, Serializable>>().toEqualTypeOf<
+      ReadonlySet<SerializationError<'Function may not be serializable'>>
+    >()
+  })
+
+  it('works for readonly maps containing serializable values', () => {
+    type Value = ReadonlyMap<string, number>
+
+    expectTypeOf<
+      ValidateSerializable<Value, Serializable>
+    >().toEqualTypeOf<Value>()
+  })
+
+  it('fails for readonly maps containing unserializable values', () => {
+    type Value = ReadonlyMap<string, () => void>
+
+    expectTypeOf<ValidateSerializable<Value, Serializable>>().toEqualTypeOf<
+      ReadonlyMap<
+        string,
+        SerializationError<'Function may not be serializable'>
+      >
+    >()
+  })
 })