You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a breaking change as it renames three duration fields in stop_visits from *_time to *_duration suffix to clearly distinguish them from timestamp fields like actual_arrival_time.
Standardized description phrasing to "Duration of time a [device] is deployed, in seconds."
CHANGELOG.md added BREAKING change entry under [Unreleased]
Reason for this change
The _time suffix creates confusion because the same table uses _time for actual timestamps (e.g., actual_arrival_time, schedule_departure_time). Users shouldn't have to read the description to know whether a field contains a point-in-time or a duration.\
The new _duration suffix makes the field type immediately clear (and aligns with common naming conventions where _time indicates timestamps and _duration indicates elapsed time).
- See related discussion in Issue #237 and Fall 2025 TIDES Issues Working Group notes from December 10.
Review checklist
Per TIDES change management policy, the following must be met before feature branch changes can merge to develop branch:
All JSON files validate
Reviewed and approved by 2+ contributors or board members
Community review status (updated August 27, 2026)
How community review works: Per the TIDES Change Management Policy, a proposal moves forward once at least three TIDES Contributors outside the originating working group publicly comment with a score: Accepted, Accepted with minor changes, or Substantially revised. A few sentences with your read of the proposal is a complete review.
Originating working group (Fall 2025 Issues Working Group, December 1 and 10, 2025 sessions): Christopher Yamas, Gabriel Sánchez Martínez, Ian Thistle, Jay Gordon, John Levin, Joey Reid, Spenser Sutinen. Their work is reflected in the proposal itself; community review comes from Contributors beyond this group.
Review so far:@lauriemerrell has approved this PR (Accepted). @mpaine-act shared naming feedback in #237 and a short scored comment here would add that review to the record.
Thanks to everyone who has weighed in on this proposal; it is moving into final consideration for v2.0. Further comments are always welcome.
Also modify samples/template/TIDES/stop_visits.csv
@jlstpaul, I updated samples/template/TIDES/stop_visits.csv to rename ramp_deployed_time to ramp_deployed_duration, kneel_deployed_time to kneel_deployed_duration, and lift_deployed_time to lift_deployed_duration in the sample header. would you be willing to submit a formal GitHub review?
@mpaine-act in #237 you made the case for keeping field names unabbreviated and self-documenting, which is where this landed, _duration suffixes rather than _dur_s.
If the outcome works for you, a short comment here with a score (Accepted / Accepted with minor changes / Substantially revised) counts toward community review on this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔄 normative changeA normative change requires approval of TIDES Board📄 specPertains to the specification itself
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a breaking change as it renames three duration fields in
stop_visitsfrom*_timeto*_durationsuffix to clearly distinguish them from timestamp fields likeactual_arrival_time.Resolves #237
Changes
spec/stop_visits.schema.jsonrenamed fields:ramp_deployed_time-->ramp_deployed_durationkneel_deployed_time-->kneel_deployed_durationlift_deployed_time-->lift_deployed_durationCHANGELOG.mdadded BREAKING change entry under[Unreleased]Reason for this change
The
_timesuffix creates confusion because the same table uses_timefor actual timestamps (e.g.,actual_arrival_time,schedule_departure_time). Users shouldn't have to read the description to know whether a field contains a point-in-time or a duration.\The new
_durationsuffix makes the field type immediately clear (and aligns with common naming conventions where_timeindicates timestamps and_durationindicates elapsed time).- See related discussion in Issue #237 and Fall 2025 TIDES Issues Working Group notes from December 10.
Review checklist
Per TIDES change management policy, the following must be met before feature branch changes can merge to
developbranch:Community review status (updated August 27, 2026)
How community review works: Per the TIDES Change Management Policy, a proposal moves forward once at least three TIDES Contributors outside the originating working group publicly comment with a score: Accepted, Accepted with minor changes, or Substantially revised. A few sentences with your read of the proposal is a complete review.
Originating working group (Fall 2025 Issues Working Group, December 1 and 10, 2025 sessions): Christopher Yamas, Gabriel Sánchez Martínez, Ian Thistle, Jay Gordon, John Levin, Joey Reid, Spenser Sutinen. Their work is reflected in the proposal itself; community review comes from Contributors beyond this group.
Review so far: @lauriemerrell has approved this PR (Accepted). @mpaine-act shared naming feedback in #237 and a short scored comment here would add that review to the record.
Thanks to everyone who has weighed in on this proposal; it is moving into final consideration for v2.0. Further comments are always welcome.