Fix partial rollout off-policy loss mask alignment#2207
Open
chengcuiping wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sample.mask_response_tokens()helper that preserves response-sideloss_masklength invariants.Motivation
When partial rollout is combined with off-policy masking, old generated tokens are masked to zero before resumed generation appends new response tokens. If
response_lengthgrows withoutloss_maskstaying aligned, training conversion can fail withlen(sample.loss_mask) == sample.response_length, as reported in #1440.This is a small stability step for the partial rollout / off-policy trajectory work discussed in #1800.
Behavior
0.1s throughappend_response_tokens().len(loss_mask) == response_lengthis preserved.Testing
CUDA_VISIBLE_DEVICES='' python -m pytest tests/test_partial_rollout_loss_mask.py tests/test_sample.py -m unitCUDA_VISIBLE_DEVICES='' pre-commit run --files slime/utils/types.py slime/rollout/sglang_rollout.py tests/test_partial_rollout_loss_mask.pygit diff --checkAll passed.
tests/test_rollout_metrics.pycould not be collected in this environment because the installedsglangpackage is missingGPU_MEMORY_TYPE_CUDA_GRAPHfromsglang.srt.constants.Refs #1440, #1800.