Skip to content

fix(rollout): honor per-call args in generate_rollout_async (GenerateState caches first args) #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sdc17 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(rollout): honor per-call args in generate_rollout_async (GenerateState caches first args) #2196

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
def7652
fix(rollout): honor per-call args in generate_rollout_async (Generate…
sdc17 Jul 10, 2026
d404bbc
fix format
sdc17 Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions slime/rollout/sglang_rollout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,10 @@ async def generate_rollout_async(

state = GenerateState(args)

# GenerateState is a singleton; submit_generate_tasks dispatches with self.args, so refresh per
# call — otherwise a prior rollout's args (e.g. eval's group_rm=False) leak into the next one.
state.args = args

# instantiate data filters
dynamic_filter = (
load_function(args.dynamic_sampling_filter_path) if args.dynamic_sampling_filter_path is not None else None
Expand Down
Loading