Skip to content

fix(tests): pass required --update-weight-local-checkpoint-dir in ext… #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MengsD wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tests): pass required --update-weight-local-checkpoint-dir in ext… #2177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions tests/test_qwen3_4B_external_pd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,13 @@ def launch_external_engines():

delta_dir_cm = tempfile.TemporaryDirectory(prefix="slime_external_pd_delta_")
delta_dir = delta_dir_cm.name
# delta + disk sync also needs a rollout-host-local dir where each host
# materializes the full HF checkpoint and patches it in place. af3d7fff
# ("Disk-level delta weight sync", #2089) made --update-weight-local-checkpoint-dir
# "Required for delta + disk" in arguments.py but did not update this test,
# so it aborted at arg validation until this dir is passed.
local_ckpt_cm = tempfile.TemporaryDirectory(prefix="slime_external_pd_localckpt_")
local_ckpt_dir = local_ckpt_cm.name
try:
ckpt_args = f"--hf-checkpoint /root/models/{MODEL_NAME}/ " f"--ref-load {TORCH_DIST_CKPT} "

Expand Down Expand Up @@ -324,6 +331,7 @@ def launch_external_engines():
"--update-weight-transport disk "
"--update-weight-encoding deltas "
f"--update-weight-disk-dir {delta_dir} "
f"--update-weight-local-checkpoint-dir {local_ckpt_dir} "
"--update-weight-delta-keep-files "
)

Expand Down Expand Up @@ -372,6 +380,7 @@ def launch_external_engines():
p.wait()
U.exec_command("pkill -9 sglang; true")
delta_dir_cm.cleanup()
local_ckpt_cm.cleanup()


if __name__ == "__main__":
Expand Down
Loading