Fix placement group crash for external engines under debug_rollout_only#2170
Open
coding-famer wants to merge 2 commits into
Open
Fix placement group crash for external engines under debug_rollout_only#2170coding-famer wants to merge 2 commits into
coding-famer wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With --rollout-external-engine-addrs + --debug-rollout-only, rollout_num_gpus gets overwritten by the remote engines' GPU count (overriding local actor dims), yet _get_placement_group_layout returns (0, 0) for this combo, the empty placement group mismatches the non-zero actor world_size and crashes with IndexError here
slime/slime/ray/actor_group.py
Line 114 in 2346470
Skip the actor-dim override when rollout_external in the debug_rollout_only branch, and return (actor_num_gpus, 0) from _get_placement_group_layout so the PG fits the placeholder training actors.
Note: this fix assumes the node has GPUs available to create the placeholder training actors.
Also updated the unit test, since the previous
(0, 0)expectation would lead to the crash.