[Style] BDYFE-186 Filter, TabBar 스타일 수정 - #181
Open
jinaaaaaaaaaaaaa wants to merge 1 commit into
Open
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
winchoose
approved these changes
Aug 29, 2026
winchoose
left a comment
winchoose
left a comment
Contributor
There was a problem hiding this comment.
고생하셨습니다! 바뀐 디자인 잘 적용해주시고 아이콘 관련된 것도 깔끔히 지워주셨네요!!
jin-evergreen
approved these changes
Aug 29, 2026
jin-evergreen
left a comment
jin-evergreen
left a comment
Member
There was a problem hiding this comment.
고생 많으셨습니다~~
사소한 코멘트 하나만 확인 부탁드립니다!
| aria-pressed={pressed} | ||
| className={cn( | ||
| 'inline-flex shrink-0 items-center gap-1.5 rounded-[30px] py-2.5 pr-4 pl-3', | ||
| 'inline-flex shrink-0 items-center gap-1.5 rounded-[30px] px-4 py-2', |
Member
There was a problem hiding this comment.
아이콘이 제거되면서 버튼 내부 요소가 label 하나만 남아서 gap-1.5는 더 이상 필요하지 않을 것 같아요.
동작에는 영향 없지만 아이콘 관련 스타일을 정리하는 김에 함께 제거해도 좋을 것 같습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Jira 이슈키
📌 Summary
Filter, TabBar 스타일 수정
📚 Tasks
🔍 Describe
🖼️ Screenshot
👀 To Reviewer