Repository navigation
fix(backend): document conventions and repair CI route wiring - #284
Merged
Tybravo merged 2 commits intoOct 4, 2026
Merged
Conversation
|
@lewistemple22 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Collaborator
|
You need to resolve the conflicts as they are too complex to resolve on the web editor Thanks |
Contributor
Author
Done. |
Collaborator
|
Well-done and thanks for the conflict you resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses the four assigned backend issues as one focused maintenance change. It documents
the CI pipeline and code-naming rules, prevents new parallel service/controller/model stacks, and
adds regression coverage for the indexer and admin DLQ route wiring. The existing upstream fixes
for the removed
webSocketServiceimport and thedlqControllerimport are preserved and coveredwithout duplicating them.
Related Issues
Closes #207
Closes #208
Closes #209
Closes #210
Changes
Issue 1 — #207: Document the CI/CD pipeline
docs/ci-pipeline.mdwith a contributor checklist at the top.MongoDB/JWT test setup, lcov artifact/comment behavior, coverage thresholds, and pnpm lockfile
requirement.
Issue 2 — #208: Document repository naming conventions
docs/code-conventions.mdcovering layering, file names, exports, canonical camelCase DItokens, and legacy-stack handling.
initializer. The former
src/services/escrowService.tsis already removed; the document recordssrc/services/escrow.service.tsas the only canonical replacement.delivery.service.tsimplementation.envimport in the legacy socket initializer while documenting itsdeprecation.
Issue 3 — #209: Remove the broken indexer websocket import
src/services/webSocketService.tsdoes not exist and nowebSocketServicereferenceremains in
indexerService.ts.tests/indexerService.test.tsto ensure the indexer service module loads without thatremoved dependency.
Issue 4 — #210: Repair admin DLQ route wiring
adminRoutes.tsimports the nameddlqControllerexport and maps the existinggetDlqEntriesandretryDlqEntrymethods.tests/adminRoutes.test.tscovering both DLQ paths and verifying unauthenticated requestsreceive 401 responses instead of an application startup/reference error.
Verification Results
git diff --check— passed.anyin untouched legacy code.jest tests/adminRoutes.test.ts tests/indexerService.test.ts --runInBand --silent --no-cache—passed, 2 suites / 3 tests.
pnpm exec tsc --noEmit— not passing on the upstream baseline because of unrelated duplicateenvironment declarations/imports and missing
TEST_UNLIMITED_MAX,validateRequest, and otherexisting symbols outside this issue scope.
tests/indexer.test.ts— blocked by the same pre-existingTEST_UNLIMITED_MAXruntime error.Acceptance Criteria
Issue 1 — #207
Closes #207and a work summary.Issue 2 — #208
are documented.
recreated.
Issue 3 — #209
webSocketServicefile was confirmed absent.webSocketServicereference remains inindexerService.ts.above.
Issue 4 — #210
dlqControlleris imported from../controllers/dlqControllerusing the verified namedexport.
getDlqEntriesandretryDlqEntryexist and are mapped to the two admin routes.configured admin account/database fixture.