STYLE: Remove ImageToImageMetricWithFeatures from Common/CostFunctions

[N-Dekker]

It appears unused. It wasn't even included with compilation.

[N-Dekker]

@mstaring @stefanklein ImageToImageMetricWithFeatures appears to be one of the very few ImageToImageMetric metrics that does not use an image sampler. So it might have been an interesting metric in the context of issue #481 and pull request #1453. However, this metric was never used. It wasn't even compiled. Is it OK if I remove it from the main branch?

[stefanklein]

Was it used by any experimental metrics? Or metrics that are not turned on by default? Kind regards, Prof. dr. ir. Stefan Klein Professor of Applied Medical Image Analysis General Chair of Biomedical Imaging Group Rotterdam (BIGR) Dept. of Radiology & Nuclear Medicine ***@***.*** +31 10 7043442<tel:+31%2010%207043442> Van: Niels Dekker ***@***.***> Verzonden: woensdag 24 juni 2026 17:26 Aan: SuperElastix/elastix ***@***.***> CC: Stefan Klein ***@***.***>; Mention ***@***.***> Onderwerp: Re: [SuperElastix/elastix] STYLE: Remove ImageToImageMetricWithFeatures from Common/CostFunctions (PR #1454) Waarschuwing: Deze e-mail is afkomstig van buiten de organisatie. Klik niet op links en open geen bijlagen, tenzij u de afzender herkent en weet dat de inhoud veilig is. Caution: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. ***@***.***N-Dekker left a comment (SuperElastix/elastix#1454)<#1454 (comment)> @mstaring<https://github.com/mstaring> @stefanklein<https://github.com/stefanklein> ImageToImageMetricWithFeatures appears to be one of the very few ImageToImageMetric metrics that does not use an image sampler. So it might have been an interesting metric in the context of issue #481<#481> and pull request #1453<#1453>. However, this metric was never used. It wasn't even compiled. Is it OK if I remove it from the main branch? - Reply to this email directly, view it on GitHub<#1454?email_source=notifications&email_token=AAF2LNJOZBRNFANDMSFS3UT5BPXG3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZZGA4DQNZVGIY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4790887521>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAF2LNOX66LA7YEV33VOAKL5BPXG3AVCNFSNUABEKJSXA33TNF2G64TZHM4TCNJYGY4TINB3JFZXG5LFHM2DOMZWGEZTAMRVGGQXMAQ>. Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS<https://github.com/notifications/mobile/ios/AAF2LNO2DNW3FSVUDTF2YFL5BPXG3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZZGA4DQNZVGIY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> and Android<https://github.com/notifications/mobile/android/AAF2LNMNLENGTBLWOOKWENL5BPXG3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZZGA4DQNZVGIY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. Download it today! You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

[N-Dekker]

Was it used by any experimental metrics? Or metrics that are not turned on by default?

In the current main tree, when doing an exhausting text search for "ImageToImageMetricWithFeatures" (including everything that is OFF by default), I cannot find any hit, other than in "itkImageToImageMetricWithFeatures.h", "itkImageToImageMetricWithFeatures.hxx", and Common/CMakeLists.txt 🤷

Just checked out an older version of the elastix source tree, at fdc611b (28-7-2008, so before my involvement). Same result: ImageToImageMetricWithFeatures is not used.

Of course, if it's still of interest, maybe we should use it! But otherwise, it's easier to remove it from the main branch.