Skip to content

Simplify newUsers.ps1 idempotency guard (fix issue #1607) #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Claude wants to merge 2 commits into from
Closed

Simplify newUsers.ps1 idempotency guard (fix issue #1607) #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73f2b36
Initial plan
Claude Mar 25, 2026
7827786
Simplify newUsers.ps1 idempotency guard (fix issue #1607)
Claude Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/playbook/Executables/AtlasModules/Scripts/newUsers.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
if (!([Security.Principal.WindowsPrincipal][Security.Principal.WindowsIdentity]::GetCurrent()).IsInRole([Security.Principal.WindowsBuiltInRole] "Administrator")) {
Start-Process powershell.exe "-NoProfile -ExecutionPolicy Bypass -File `"$PSCommandPath`"" -Verb RunAs; exit
# Guard against re-running on already-configured accounts (e.g., after profile reset)
$sid = [System.Security.Principal.WindowsIdentity]::GetCurrent().User.Value
if ((Get-ItemProperty -Path "HKLM:\SOFTWARE\AtlasOS\UserSetup" -Name $sid -ErrorAction SilentlyContinue).$sid -eq 1) { exit }

if (!([Security.Principal.WindowsPrincipal][Security.Principal.WindowsIdentity]::GetCurrent()).IsInRole([Security.Principal.WindowsBuiltInRole] "Administrator")) {
Start-Process powershell.exe "-NoProfile -ExecutionPolicy Bypass -File `"$PSCommandPath`"" -Verb RunAs; exit
}

$windir = [Environment]::GetFolderPath('Windows')
Expand Down Expand Up @@ -51,6 +55,10 @@ $Browser
& "$atlasModules\Scripts\taskbarPins.ps1" $Browser
Set-ItemProperty -Path "HKCU:\SOFTWARE\Microsoft\Windows\CurrentVersion\Search" -Name "SearchboxTaskbarMode" -Value 1

# Mark setup complete for this SID to prevent re-runs after profile reset
New-Item -Path "HKLM:\SOFTWARE\AtlasOS\UserSetup" -Force | Out-Null
New-ItemProperty -Path "HKLM:\SOFTWARE\AtlasOS\UserSetup" -Name $sid -Value 1 -PropertyType DWord -Force | Out-Null

# Leave
Start-Sleep 5
Start-Sleep 5
logoff