Repository navigation
Reject zero address in escrow add_allowed_token - #1857
Merged
Merged
Conversation
|
@David-Isaac-web Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject zero address in escrow add_allowed_token
What was solved
#1782 — Fix:
add_allowed_tokendoes not reject the zero addressAdd a zero-address guard to the escrow contract's
add_allowed_tokenso it returnsError::InvalidAddressinstead of accepting the zero address, plus a test covering the rejection.Addressed:
add_allowed_token, validate the provided token address is non-zero and returnError::InvalidAddresswhen it is the zero addressadd_allowed_tokenrejects the zero address withError::InvalidAddressChanges
contracts/escrow/src/errors.rs(modify)Approach
InvalidAddressvariant to theErrorenum if it does not already exist.add_allowed_tokento reject the zero address by returningError::InvalidAddressbefore any state mutation.add_allowed_tokenwith the zero address returnsError::InvalidAddress.Issues
Closes #1782