Skip to content

Fix: claim_vested_payout does not check that the match is Completed #1778

Closed

Description

@yahia008

Category: Escrow Contract - Bug
Priority: Low
Estimated Time: 20 minutes

Description:
claim_vested_payout only checks for an existing vesting record; it does not verify that the match is in Completed state. If a vesting record is somehow created for an Active match, the claim could proceed while the match is still in progress.

Tasks:

  • Add a state guard: return Error::InvalidState if match.state != MatchState::Completed
  • Add a test

Activity

  1. added
    bugSomething isn't working
    trivial100 pts — simple task
    wave-readyFunded Drips Wave issue
    rustPull requests that update rust code
    on Oct 15, 2026
  2. fate-lab commented on Oct 20, 2026

    @fate-lab

    @fate-lab has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hello, I would like to work on this issue.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @fate-lab to this issue.

  3. rilwanubala commented on Oct 22, 2026

    @rilwanubala
    Contributor

    @rilwanubala has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    hi, i would like to work on this issue

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @rilwanubala to this issue.

  4. drips-wave commented on Oct 22, 2026

    @drips-wave

    Congratulations, @rilwanubala! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @rilwanubala: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  5. grantfox-oss commented on Oct 23, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @rilwanubala's PR #1872 was approved and merged by @famvilianity-eng.

    🏆 @rilwanubala: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (328 total points). Track your full progress on GrantFox.

    👏 Great work, @rilwanubala! Keep contributing to StellarCheckMate.

  6. drips-wave commented on Oct 23, 2026

    @drips-wave

    This issue has been completed by @rilwanubala as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @rilwanubala: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programbugSomething isn't workingrustPull requests that update rust codetrivial100 pts — simple taskwave-readyFunded Drips Wave issue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions