Skip to content

Fix: record_snapshot overwrites the oldest entry silently with no event #1768

Closed

Description

@yahia008

Category: Escrow Contract - Bug
Priority: Low
Estimated Time: 30 minutes

Description:
When the snapshot ring buffer is full, record_snapshot wraps around and overwrites the oldest entry without emitting any event or incrementing a lost-entry counter. Off-chain indexers cannot detect the data loss.

Tasks:

  • Emit a match/snapshot_overwritten event when a slot is recycled
  • Document the wrap-around behaviour in docs/architecture.md

Activity

  1. added
    bugSomething isn't working
    trivial100 pts — simple task
    wave-readyFunded Drips Wave issue
    rustPull requests that update rust code
    on Oct 15, 2026
  2. Jerry-22B commented on Oct 16, 2026

    @Jerry-22B

    @Jerry-22B has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I would love to help fix this issue to ensure off-chain indexers can reliably track data retention and never miss recycled entries. To resolve this, I will update record_snapshot to emit a distinct event whenever the ring buffer wraps around and recycles an existing slot, and I will update docs/architecture.md to clearly document this wrap-around behavior for integrators.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Jerry-22B to this issue.

  3. Joshua13-stack commented on Oct 20, 2026

    @Joshua13-stack
    Contributor

    @Joshua13-stack has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Please, I’d appreciate the opportunity to work on this issue. I’ve carefully reviewed the requirements and have a clear understanding of what needs to be addressed. I’m confident I can resolve the problem properly and ensure the final implementation meets all the stated criteria. I kindly ask you to allow me the opportunity to proceed and deliver a reliable solution.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Joshua13-stack to this issue.

  4. drips-wave commented on Oct 20, 2026

    @drips-wave

    Congratulations, @Joshua13-stack! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @Joshua13-stack: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  5. added a commit that references this issue on Oct 20, 2026
    81df950
  6. grantfox-oss commented on Oct 21, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @Joshua13-stack's PR #1849 was approved and merged by @yahia008.

    🏆 @Joshua13-stack: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (105 total points). Track your full progress on GrantFox.

    👏 Great work, @Joshua13-stack! Keep contributing to StellarCheckMate.

  7. drips-wave commented on Oct 21, 2026

    @drips-wave

    This issue has been completed by @Joshua13-stack as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @Joshua13-stack: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Stellar WaveIssues in the Stellar wave programbugSomething isn't workingeventsrustPull requests that update rust codetrivial100 pts — simple taskwave-readyFunded Drips Wave issue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions