This repository was archived by the owner on Oct 21, 2026. It is now read-only.
Repository navigation
Bump the corpus to c874a95 (corpus bump 41) - #399
Merged
Merged
Conversation
Corpus master c874a956 is the merge of corpus PR 698 (bump 41, writers QJ and QK, plus the workflow fix for the move to aldevtools). The oracle files are copied unchanged from the green PR run 39550736920, whose head d0d77cd0 has the same tree as c874a956. Done with tools/corpus_bump.sh, then the pin moved from d0d77cd0 to c874a956. The oracle README names the new corpus repository. 84363 ClearAll_InBaseAppPage_ExtensionGlobal now passes on BC 27 and 28 (QK writes its setup rows). The BC 29 baseline follows in the next commits.
Writer QK changed these tests on purpose: they now write their own Company Information row (misc/lt-qk-setup-rows/QkSetupRows.al), with a Picture and address fields, instead of reading the corpus database's demo row. The old passes were of the old tests. The runtime now refuses them: the dataset header's CompanyLogo encoding and the company address format are not built. 67755 PW_DumpPlain_Lines01To18 67755 PW_DumpPlain_Lines19To36 70535 PW_Dump_Lines001To016 70535 PW_Dump_Lines017To032 70535 PW_Dump_Lines081To096 70535 PW_Dump_Lines097To112 70535 PW_Dump_Lines113To128
84363 ClearAll_InBaseAppPage_ExtensionGlobal now passes on BC 29 too (QK writes its setup rows).
… c874a95 No platform column became pinned; only the commit in the header changes.
pages/lt-qj-part-propagation/QjPartPropagation.al is on corpus master now. The two assumptions that flagged its behavior until the bump landed are removed, and the code cites the file's lines: - part-update-propagation-both-refreshes-host: a part's Update(false) after its code changed the host row makes the host read its row again in every UpdatePropagation mode (:508, :545, :582); an unsaved host edit is saved first (:623, :661, :699); a card action that only called SaveRecord reads OnAfterGetRecord alone, then the parts (:511). - part-saverecord-in-validate-keeps-xrec: SaveRecord in a subform OnValidate keeps xRec; for a new row xRec stays the blank new row (:733, :735, :763, :764, :766). One branch stays unpinned: a NEW part row with UpdatePropagation = Both (the QJ tests use a stored row). It keeps its behavior under the narrower assumption part-update-new-row-both-refreshes-host.
…Ledger Setup (writer QK) Corpus bump 41 (misc/lt-qk-setup-rows/QkSetupRows.al) makes Literals_FieldCaption and Expressions_FieldCaption of QdCaptionClassAreas.al write their own General Ledger Setup and Dimension rows. Without test data, a caption of areas 1 and 101 was refused because the runtime has no demo setup row. It is now answered when the running test wrote General Ledger Setup before any caption of those areas was resolved in the session (Base Application's resolvers are SingleInstance and keep the row they read first), and only for what QK writes: area 101 type 0 (LCY Code) and area 1 '1,1' (Global Dimension 1 Code). Other types stay refused. General Ledger Setup joins the demo tables: a Count or IsEmpty of it before the test wrote to it is refused (QdCaptionClassAreas.al:804 QF_GLSetup_CorpusRow, which would otherwise fail). What an earlier test wrote no longer counts for the next test: the QK tests put the demo values back, which leaves the runtime with the install-code row. Two new baseline cases per major: 86504 Literals_FieldCaption and Expressions_FieldCaption.
StefanMaron
enabled auto-merge
October 21, 2026 07:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
uses:fix for the move to aldevtools). The oracle files are copied unchanged from the green run of PR 698 (39550736920). That run's head d0d77cd0 has the same tree as c874a956. The master push run of c874a956 (39556438011) was still running when I set the pin.tools/corpus_bump.sh 39550736920. Then I moved the pin from d0d77cd0 to c874a956 and reran--update-baselinefor BC 27, 28, 29 with the shared HOME. Harness counts, both coverage maps and the pinned-columns header are regenerated. The oracle README names the new corpus repository (aldevtools).part-update-propagation-both-refreshes-hostandpart-saverecord-in-validate-keeps-xrecare removed. The code cites pages/lt-qj-part-propagation/QjPartPropagation.al: host re-read in every UpdatePropagation mode (:508, :545, :582), unsaved host edit saved first (:623, :661, :699), SaveRecord-only card action (:511), xRec after SaveRecord in a subform OnValidate (:733, :735, :763, :764, :766). One branch is still unpinned: a NEW part row with UpdatePropagation = Both (the QJ tests use a stored row). It keeps its behavior under the narrower assumptionpart-update-new-row-both-refreshes-host.1,1(Global Dimension 1 Code). Other types stay refused (QdCaptionClassAreas.al:267, :269, :311).Numbers (pass / fail / not run)
Before: main at 35df818 with the old pin 0075e2f; baseline lines 13891 / 13929 / 13957 (BC 27 / 28 / 29).
Cases that fail, by cause (17 per major)
x.t=0), the runtime the same row. The runtime also refreshes the part once more after the host's second read, and the subform runs OnAfterGetCurrRecord twice. This is the same open-path xRec gap as QiHostSaveParts.al. It belongs to the lane working on pages and host SaveRecord with parts, so I left it.Cases that are refused, by cause (QK codeunits, BC 29)
Needs a decision (next lane, not built here)
part-update-new-row-both-refreshes-host): needs a probe.Assumptions
part-update-propagation-both-refreshes-host,part-saverecord-in-validate-keeps-xrec(bump 41 pins them).part-update-new-row-both-refreshes-host(the unpinned new-row branch of the removed one, same behavior as before).Gates
./check.shgreen after merging origin/main.corpus_resolve_deps --ignored: 4 of 4 pass.https://claude.ai/code/session_01MifNJNPViEXwK4p83TH2DQ