SR-38 Convert Bellhop to Typescript#110
Merged
Merged
Conversation
TensAndTwenties
requested review from
902seanryan,
aberkie and
corinnejean
as code owners
corinnejean
approved these changes
Jun 30, 2026
jeremymccurdy-redspace
requested changes
Jul 2, 2026
jeremymccurdy-redspace
left a comment
jeremymccurdy-redspace
left a comment
Contributor
There was a problem hiding this comment.
The code for this looks good, but it looks like the code documentation was lost in the conversion. Can you re-add that?
Contributor
Author
Good call! I restored the old comments for /src files, with adjustments for TS changes. I left out the @param types since Typescript makes it explicit. |
jeremymccurdy-redspace
approved these changes
Jul 7, 2026
jeremymccurdy-redspace
left a comment
jeremymccurdy-redspace
left a comment
Contributor
There was a problem hiding this comment.
Looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bellhop project has been converted to Typescript! All the package.json commands, like linting, automated tests, and builds are running. I verified the new Typescript version of Bellhop functions as expected in the games website by running the site locally with a local reference to the new Bellhop Typescript