Repository navigation
fix: require saved routes for share links - #19
Merged
SpencerLiang0114 merged 1 commit intoOct 12, 2026
Merged
SpencerLiang0114 merged 1 commit into
SpencerLiang0114 merged 1 commit into
Conversation
|
@victory-c is attempting to deploy a commit to the spencerliang0114's projects Team on Vercel. A member of the Team first needs to authorize it. |
SpencerLiang0114
approved these changes
Oct 12, 2026
SpencerLiang0114
left a comment
Owner
There was a problem hiding this comment.
Reviewed saved-route and authentication gating, sharing API behavior, and component regressions. No blocking findings. Combined with PR #18: all 32 web tests, lint, TypeScript, and production build pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require a saved route and authentication before enabling Share link. Explain the requirement accessibly instead of copying a local-only results URL. Preserve saved-route token sharing and export behavior; do not save user data implicitly.
Validation: 29 tests passed; ESLint, TypeScript and production build passed. Added component coverage for unsaved routes, saved token links and API failure. Testing Library dependencies are development-only.