Skip to content

fix: require saved routes for share links - #19

Merged
SpencerLiang0114 merged 1 commit into
SpencerLiang0114:mainfrom
victory-c:fix/require-saved-route-for-sharing
Oct 12, 2026
Merged

SpencerLiang0114 merged 1 commit into
SpencerLiang0114:mainfrom
victory-c:fix/require-saved-route-for-sharing

Conversation

@victory-c

Copy link
Copy Markdown
Contributor

Summary

Require a saved route and authentication before enabling Share link. Explain the requirement accessibly instead of copying a local-only results URL. Preserve saved-route token sharing and export behavior; do not save user data implicitly.

Validation: 29 tests passed; ESLint, TypeScript and production build passed. Added component coverage for unsaved routes, saved token links and API failure. Testing Library dependencies are development-only.

@vercel

vercel Bot commented Oct 11, 2026

Copy link
Copy Markdown

@victory-c is attempting to deploy a commit to the spencerliang0114's projects Team on Vercel.

A member of the Team first needs to authorize it.

@SpencerLiang0114 SpencerLiang0114 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed saved-route and authentication gating, sharing API behavior, and component regressions. No blocking findings. Combined with PR #18: all 32 web tests, lint, TypeScript, and production build pass.

@SpencerLiang0114
SpencerLiang0114 merged commit af4293a into SpencerLiang0114:main Oct 12, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants