Repository navigation
Show imperial conversions next to metric route values - #14
Merged
Merged
Conversation
Distances now read "8.4 km (5.2 mi)" and elevations "142 m (466 ft)" across route cards, saved routes, Strava picker, route summary and the distance-goal presets. The elevation chart gains a feet axis on the right and miles under each km label. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
@victory-c is attempting to deploy a commit to the spencerliang0114's projects Team on Vercel. A member of the Team first needs to authorize it. |
2 of 8 tasks
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds imperial equivalents alongside every metric route value where the unit system matters. Metric stays primary; the imperial value is in parentheses.
lib/units.tshelper (formatDistance,formatElevation,formatMiles,formatFeet) plus unit tests8.4 km (5.2 mi),+118 m (+387 ft)5 km (3.1 mi),42.2 km (26.2 mi), and the custom slider labelUnchanged on purpose: duration, avg grade (%), scores, and lat/lng — those are unit-system independent.
Test plan
pnpm vitest run(15 passing, incl. new units tests)pnpm tsc --noEmit,pnpm eslint src🤖 Generated with Claude Code