feat: add composable racing-line overlays to Analyse - #255
Open
Korupt-virus wants to merge 3 commits into
Open
Conversation
Collaborator
|
Can you expand on what this does? |
Contributor
Author
Collaborator
Collaborator
|
we also might want to turn the toggles into a drop down menu, gonna run out of space |
Contributor
Author
what about doing a drop down? like what if i want segments, my inputs, and optimal all at the same time? |
Collaborator
thats what i am suggesting. toggles go into the dropdown menu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Behavior
Racing line displays reference geometry supplied by the game data. It is not a generated or ML-derived optimal line. In 3D, only nearby line sections render around the current car position.
Testing
bunx oxlint .bun run typecheckbun test ./client/test/static-track-drawing.test.tsbun test test/tooling/theme-contract.test.ts --timeout 60000bun test test/tooling/changelog.test.ts --timeout 60000Full seeded shared-controls scenario still reaches the unchanged speed-readout assertion at
playwright/tests/seeded/analyse/controls.ts:75; focused racing-line scenario passes.Closes #103