feat(telemetry): classify laps and model analysis eligibility - #231
Draft
Korupt-virus wants to merge 12 commits into
Draft
feat(telemetry): classify laps and model analysis eligibility#231Korupt-virus wants to merge 12 commits into
Korupt-virus wants to merge 12 commits into
Conversation
This was
linked to
issues
Aug 9, 2026
Korupt-virus
changed the base branch from
folder-cleanup
to
fix/canonical-live-telemetry-pr
August 11, 2026 01:01
Base automatically changed from
fix/canonical-live-telemetry-pr
to
folder-cleanup
August 11, 2026 11:15
Korupt-virus
force-pushed
the
issue-229-valid-non-pace-laps
branch
from
August 11, 2026 20:58
d9a9390 to
e3bd57d
Compare
Korupt-virus
marked this pull request as ready for review
August 11, 2026 20:59
|
Found 4 test failures on Blacksmith runners: Failures
|
…ace-laps # Conflicts: # client/src/components/analyse/AnalyseLapHeader.tsx # client/src/components/comparison/ComparisonSelectors.tsx # server/db/experiment-lap-queries.ts # server/db/lap-meta.ts # server/db/lap-read-queries.ts # server/db/migrations.ts # server/db/schema.ts # server/db/session-queries.ts # server/games/iracing/import-ibt.ts # server/laps/archive.ts # server/motec/import.ts # server/routes/laps/transfer-routes.ts # server/session-capture/import-capture.ts # server/session-capture/import-pipeline.ts # server/telemetry/pipeline-ports.ts # shared/racing/sessions/types.ts # test/db/migrations/migration-regression.test.ts
Contributor
Korupt-virus
marked this pull request as draft
August 13, 2026 03:10
…roper handling of session rotation and quality persistence
… fidelity and channel profiles
…ss import and reprocessing workflows
- Implemented a KunosReplayClock to manage timestamps for replay frames. - Updated parsing functions to accept and utilize timestamps from Kunos recordings. - Modified the packTriplet and unpackTriplet functions to include optional timestamp storage. - Ensured that ACC and AC Evo parsers now correctly handle and reconstruct timestamps during replay. - Added tests to verify timestamp handling for both native and legacy frames. - Updated import routes and recording support to accommodate new timestamp logic.
… and enhance source fidelity
…g lap fallback logic
- Consolidated import statements for better readability in driver profile tests. - Updated the pool key test to include quality identity for laps and improved assertions. - Added requiredPolicyIds to CurationSpec in arms curation tests for consistency. - Enhanced outcome metrics tests to include new quality checks and added new tests for metadata metrics. - Improved eligibility policies tests with additional checks for missing samples and source treatments. - Refactored evidence retention tests to include new quality schema versions and added checks for stale eligibility snapshots. - Added new tests for track quality evidence to ensure proper handling of quality metrics in API responses. - Enhanced lap export/import roundtrip tests to validate handling of missing capture members in manifests. - Improved telemetry pipeline tests to ensure proper snapshot handling and quality finalization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light.png)






Summary
Change inventory
Lap classification and pace selection
Telemetry quality and evidence modeling
Shared eligibility policies
Version 1 includes:
Policies return eligible, eligible with warning, ineligible, or unknown plus policy version, reason codes, supporting evidence, required channels, and optional affected range. Broad analyses can tolerate minor localized gaps while strict transient analysis requires stronger cadence and contiguous coverage.
Persistence, APIs, consumers, and retention
Issue alignment
Verification
bun test test/tooling/changelog.test.ts test/lap-analysis/quality-model.test.ts test/lap-analysis/quality-source-parity.test.ts test/db/quality-event-linkage.test.ts test/routes/quality-routes.test.ts test/session-capture/import-quality-errors.test.ts test/client/lap-quality-badge.test.ts --timeout 60000Closes #222
Closes #229
Closes #236