Skip to content

fix: accept legacy Azure Resource Manager audience in JWT validation #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rootsecdev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: accept legacy Azure Resource Manager audience in JWT validation #203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion client/rest/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,26 @@ func ParseBody(accessToken string) (map[string]interface{}, error) {
}
}

// Entra ID issues tokens for the Azure Resource Manager under either of two
// registered identifier URIs; ARM accepts both, but AzureHound only compares
// against the canonical endpoint, so normalize the legacy form.
var audAliases = map[string]string{
"https://management.core.windows.net": "https://management.azure.com",
"https://management.core.usgovcloudapi.net": "https://management.usgovcloudapi.net",
"https://management.core.chinacloudapi.cn": "https://management.chinacloudapi.cn",
}

func ParseAud(accessToken string) (string, error) {
if body, err := ParseBody(accessToken); err != nil {
return "", err
} else if aud, ok := body["aud"].(string); !ok {
return "", fmt.Errorf("invalid 'aud' type: %T", body["aud"])
} else {
return strings.TrimSuffix(aud, "/"), nil
aud = strings.TrimSuffix(aud, "/")
if canonical, ok := audAliases[aud]; ok {
return canonical, nil
}
return aud, nil
}
}

Expand Down
Loading