Repository navigation
feat(app): add keyboard skip-link, offline network banner, and 404 route fallback - #983
Open
area523ufo wants to merge 1 commit into
Open
area523ufo wants to merge 1 commit into
area523ufo wants to merge 1 commit into
Conversation
…ute fallback (closes Sorokit#966)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhances
src/App.tsxandsrc/lib/nav-routes.tswith an accessible skip-to-main-content link, a liveonline/offlinenetwork status alert banner, and a 404 fallback view with recovery navigation for unknown paths.Changes
resolveRoute()insrc/lib/nav-routes.tsto distinguish registered routes from unknown paths.#main-content), an offline status banner (role="status"), and a 404 fallback card with a button to return to the dashboard insrc/App.tsx.src/App.test.tsx(9/9 passing).Closes #966