Repository navigation
fix(staking): enforce unbonding period on claim, epoch rewards, and commission validation (closes #972) - #978
Open
area523ufo wants to merge 1 commit into
Conversation
…ation compounding, and epoch-aligned unbonding (closes Sorokit#972)
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #972
Summary
Hardens
src/lib/staking.tsstaking manager calculations and validations:claimUnbonded(positionId, now)and updatedgetClaimablePositions(now)to verifypos.status === 'unbonding'andnow >= pos.unbondingEnd, transitioning claimed positions to'claimed'.0–100%): AddedvalidateCommission(commission)inaddValidatorand reward calculations so invalid/negative or>100%commission rates throw a descriptive error.calculateEpochReward(pos, validator, epochs, epochsPerYear)alongside time-basedcalculatePendingReward.Verification
src/lib/staking.test.tscovering unbonding period enforcement, commission bounds validation, and epoch reward calculations.npx vitest run.