Repository navigation
fix: address assigned issues #863, #867, #868 - #1027
Merged
k-deejah merged 1 commit intoOct 22, 2026
Merged
Conversation
- ContractEventFeed: harden persisted fromLedger parsing/writes and add remount, contract-switch, and sessionStorage regression coverage (Sorokit#863) - NFTScreen: verify address-scoped NFT fetches and the disconnected state (Sorokit#867) - StakingDashboard: use the mock client pattern, cover delegation adjustment, and refresh the account after claim-all (Sorokit#868)
|
@investorUsman Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #863
Resolves #867
Resolves #868
Summary
This PR addresses the three remaining assigned issues in one comprehensive change set. Several pieces of the underlying work had already landed on
mainunder earlier issue numbers (#732 and #737), so this PR hardens the persistence logic and extends the existing screen/dashboard test files to explicitly cover every acceptance criterion.Changes
#863 — ContractEventFeed: preserve
fromLedgeracross remountsreadPersistedFromLedgerso corrupted, non-numeric, or negative sessionStorage values are ignored instead of being forwarded togetEvents(...)asNaN.persistFromLedgeragainst non-finite/negative ledger values.contractIdchanges.NaN.fromLedgerprecedence tests continue to pass.#867 — NFTScreen tests
NFTScreen.test.tsxto cover the loading, error, empty, and success states (already present) plus:nft.getNftsis called with the connected wallet address.createMockClient()fromsrc/lib/mock-client.ts.#868 — StakingDashboard tests
StakingDashboard.test.tsxusing thecreateMockClient()pattern in the mocked context.refreshAccountis invoked).handleClaimAllnow refreshes the connected account after a successful claim so balances propagate outside the dashboard; the claim-all test asserts that refresh.Testing
npx eslinton all changed files: cleannpx tsc -b --noEmit: cleanNotes
No unrelated files are included in this PR.