[investorUsman]

Resolves #865
Resolves #863
Resolves #867
Resolves #868

Summary

Single comprehensive PR resolving all four assigned issues.

• useOutsideClick — document event listener not cleaned up when enabled toggles to false #865 — useOutsideClick now always returns a cleanup that removes the pointerdown/touchstart/mousedown document listeners, so toggling enabled back to false (or unmounting) can no longer leave a dangling document-level listener.
• ContractEventFeed — fromLedger resets to default on remount — events missed while component was hidden #863 — ContractEventFeed preserves the last-seen ledger per contractId across unmount/remount, and the persisted value is now validated so corrupted data can't be forwarded to getEvents as NaN.
• NFTScreen has no test file — add NFTScreen.test.tsx #867 — NFTScreen.test.tsx covers loading, error, empty, success, address-scoped fetches, and the disconnected state.
• StakingDashboard has no test file — add StakingDashboard.test.tsx #868 — StakingDashboard.test.tsx covers validator rendering, the delegate flow, rewards totals, delegation adjustment, and claim-all.

Changes

#865 — useOutsideClick

• Removed the early if (!enabled) return; so the effect always provides a cleanup.
• Listener registration is guarded by if (enabled), while cleanup always calls document.removeEventListener for all three event types.
• Added a regression test asserting the exact listener instances registered are the ones removed when disabled.

#863 — ContractEventFeed

• readPersistedFromLedger ignores non-numeric/negative sessionStorage values and falls back to the prop/default window.
• persistFromLedger refuses to write non-finite or negative ledgers.
• Tests cover persistence under the contract-specific key, clearing the previous contract's key on contractId change, corrupted values, and the unmount/remount resume path.

#867 — NFTScreen tests

• Added assertions that nft.getNfts is called with the connected address and that the disconnected prompt renders.
• Uses createMockClient() from src/lib/mock-client.ts.

#868 — StakingDashboard tests

• Uses the createMockClient() pattern in the mocked context.
• Added an inline delegation-adjustment test that verifies delegated totals update and refreshAccount is called.
• handleClaimAll now refreshes the connected account after claiming; the claim-all test asserts that refresh.

Testing

• Focused run for the four affected files: 4 files, 78 tests passed
• Full Vitest suite: 100 files, 2039 tests passed
• ESLint on changed files: clean
• tsc -b --noEmit: clean

Notes

Only the files relevant to these four issues are included; unrelated untracked files were intentionally left out.

[drips-wave]

@investorUsman Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits