Skip to content

[3.0] Writes a column type MySQL knows in the SQL that rebuilds a table #9653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
albertlast wants to merge 1 commit into
base: release-3.0
Choose a base branch
from
+9 −3
Open

[3.0] Writes a column type MySQL knows in the SQL that rebuilds a table #9653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions Sources/Db/APIs/MySQL.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1169,10 +1169,16 @@ public function table_sql(string $table_name): string
$inner_lines = [];

foreach ($structure['columns'] as $column) {
$line = ' `' . $column['name'] . '` ' . $column['type'];
// The structure reports SMF's own name for a type that MySQL
// spells differently -- a varbinary(16) holding an address comes
// back as an inet -- so it has to be turned back into something
// MySQL knows before it can be written into a CREATE TABLE.
list($type, $size) = $this->calculate_type($column['type'], $column['size']);

if (is_numeric($column['size'])) {
$line .= '(' . $column['size'] . ')';
$line = ' `' . $column['name'] . '` ' . $type;

if (is_numeric($size)) {
$line .= '(' . $size . ')';
}

if (!empty($column['unsigned'])) {
Expand Down