Skip to content

[3.0] Returns a bool from the substep that backs up a table #9649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
albertlast wants to merge 1 commit into
base: release-3.0
Choose a base branch
from
+4 −1
Open

[3.0] Returns a bool from the substep that backs up a table #9649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Sources/Maintenance/Tools/Upgrade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1380,7 +1380,10 @@ public function backupRecommended(): bool
*/
public function doBackupTable($table): bool
{
return Db::$db->backup_table($table, 'backup_' . $table);
// The database layer answers with whatever its query returned, which is
// a result object on PostgreSQL and true on MySQL. Only an outright
// false means the table was not copied.
return Db::$db->backup_table($table, 'backup_' . $table) !== false;
}

/******************
Expand Down