Repository navigation
Conversation
Implement core refactor
* docs refactor * docs * implement tool deep linking
* implement full nrps support * run ci * ci
* refactor full ags support * cleanup deprecation warning * remove legacy apis
…part1-core-refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes tool-side AGS support on top of the prior core, deep-linking, and NRPS work. It refactors AGS into
typed endpoint/client/parser/scope-policy modules and adds full line item CRUD, score posting, results retrieval,
structured errors, telemetry, and compatibility hooks.
This PR should be reviewed and landed after #44
What Changed
Lti_1p3.Tool.Services.AGS.from_launch_claim/1Lti_1p3.Tool.Services.AGS.list_line_items/3Lti_1p3.Tool.Services.AGS.read_line_item/4Lti_1p3.Tool.Services.AGS.create_line_item/4Lti_1p3.Tool.Services.AGS.update_line_item/5Lti_1p3.Tool.Services.AGS.delete_line_item/4Lti_1p3.Tool.Services.AGS.post_score/5Lti_1p3.Tool.Services.AGS.list_results/4Lti_1p3.Tool.Services.AGS.fetch_all_results/4Lti_1p3.Services.HTTP.RequestWhy
AGS was the last major incomplete tool-side service area. This PR brings line items, scores, and results onto the same
stricter, typed, telemetry-aware model as the rest of the
1.0.0stack and removes the older partial helperinterface.
Reviewer Notes
Focus review on:
Most of the diff against
masteris inherited from the first three PRs. The incremental review surface is the AGSrefactor, the shared request helper, and the associated docs/tests.
Documentation
docs/tool_ags_guide.mddocs/features/tool-ags/*docs/telemetry.mdREADME.mdCHANGELOG.mdMigration Notes
This PR removes the legacy AGS helper API in favor of the typed AGS interface. Consumers should migrate to
from_launch_claim/1plus the operation-specific APIs and userequired_scopes/1for token scope requests.