Repository navigation
feat(series): list links to every metadata source - #1487
Merged
Merged
Conversation
revam
added this pull request to stack #1490
October 3, 2026 17:38
harshithmohan
force-pushed
the
split/10-series-source-links
branch
from
October 3, 2026 17:43
aea73af to
417f52b
Compare
revam
force-pushed
the
split/10-series-source-links
branch
from
October 3, 2026 18:48
417f52b to
8260877
Compare
revam
force-pushed
the
split/10-series-source-links
branch
from
October 3, 2026 19:04
8260877 to
f226b2c
Compare
harshithmohan
force-pushed
the
split/10-series-source-links
branch
3 times, most recently
from
October 4, 2026 08:00
8640ac1 to
b7fe140
Compare
harshithmohan
force-pushed
the
split/10-series-source-links
branch
from
October 5, 2026 17:38
b7fe140 to
21a0c5d
Compare
harshithmohan
removed this pull request from stack #1490
October 5, 2026 17:42
harshithmohan
added this pull request to stack #1492
October 5, 2026 17:42
harshithmohan
force-pushed
the
split/10-series-source-links
branch
from
October 6, 2026 13:51
21a0c5d to
5824a59
Compare
harshithmohan
removed this pull request from stack #1492
October 6, 2026 13:53
harshithmohan
added this pull request to stack #1494
October 6, 2026 13:53
harshithmohan
removed this pull request from stack #1494
October 6, 2026 13:54
harshithmohan
added this pull request to stack #1495
October 6, 2026 13:55
harshithmohan
removed this pull request from stack #1495
October 6, 2026 16:37
harshithmohan
added this pull request to stack #1496
October 6, 2026 16:37
hidden4003
force-pushed
the
split/10-series-source-links
branch
from
October 10, 2026 08:44
5824a59 to
414a5df
Compare
- Listed the series' links to every source after AniDB and TMDB, from `IDs.Linked`, with `Series/{id}/Metadata/{source}/CrossReferences` telling series from movies
- Added a row to link each source `GET Metadata/Source` reports enabled
- Opened other sources' entries on the linking page, as the server sends no site URL for them; TMDB keeps its external link
- Renamed `SeriesMetadata` to `SeriesMetadataLink`, which takes a `source` and its `sourceName`
hidden4003
force-pushed
the
split/10-series-source-links
branch
from
October 10, 2026 14:14
414a5df to
0d4ef2d
Compare
The cross-references query is disabled once a source has no linked IDs, and invalidating skips disabled queries, so the removed row kept rendering from the cache.
The linking page falls back to TMDB for a source the server does not list, so a link to such a source opened the wrong page. Show those links without the linking page link or the actions.
Before the sources load, a linked source cannot be told from an unlisted one, so every one showed read-only and then switched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The series overview listed only AniDB and TMDB among its metadata sites, though a series can now be linked to any source (
IDs.Linked).What changed
GET /api/v3/Series/{id}/Metadata/{source}/CrossReferencestelling series from movies.SeriesMetadatabecomesSeriesMetadataLink, taking asourceand itssourceName; sources are compared ignoring case throughisSameKey.Where to look first
src/components/Collection/SeriesSourceLinks.tsx: the new list.src/components/Collection/SeriesMetadataLink.tsx: one source's rows.Feedback wanted
Layout of the list with several sources.
Stack
Part 10 of 12 in the split of #1477. Below: Part 9, linking any metadata source. Above: Part 11, site links, source icons and the source picker.
Testing
pnpm tscheck,pnpm lint,pnpm testandpnpm buildpass at this branch's tip. Manual, on 6.0.0-dev.495: a series linked to TMDB and one other source shows both.