Repository navigation
fix(Install Dialogs): rename custom_maximum_size, now a native Control property - #560
Merged
Merged
Conversation
…l property
Godot 4.7 added a native Control.custom_maximum_size, so the exported
variable of the same name in install_location_dialog.gd and
install_options_dialog.gd fails to parse ("Member redefined"), and the
game launch menu that uses these dialogs breaks.
Rename it to scroll_maximum_size (it caps the scroll container) in both
scripts and their scenes.
Fixes ShadowBlip#540
pastaq
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #540.
Problem
Godot 4.7 added a native
Control.custom_maximum_size. The exportedcustom_maximum_sizeininstall_location_dialog.gdandinstall_options_dialog.gdnow fails to parse (Member "custom_maximum_size" redefined (original in native class 'Control')). That breaks the game launch menu, which uses these dialogs.Changes
The variable is renamed to
scroll_maximum_size, because it caps the dialog's scroll container. The rename covers both scripts and the.tscnvalues. Behaviour is unchanged.Testing
Tested on v0.46.1 with this patch, exported with Godot 4.7.1 (arm64). The parse errors are gone at startup.