Skip to content

fix(OSK): regression where backspace and other non-unicode keys would be sent #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShadowApex merged 1 commit into from
Jan 18, 2026
Merged

fix(OSK): regression where backspace and other non-unicode keys would be sent #503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions core/ui/common/osk/on_screen_keyboard.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ enum MODE_SHIFT {
@export var instance: KeyboardInstance = preload("res://core/global/keyboard_instance.tres")
var _mode_shift: MODE_SHIFT = MODE_SHIFT.OFF
var _last_input_focus: int
var logger := Log.get_logger("OSK")
var logger := Log.get_logger("OSK", Log.LEVEL.INFO)

@onready var rows_container := $%KeyboardRowsContainer as VBoxContainer

Expand Down Expand Up @@ -369,6 +369,7 @@ func _handle_native(key: KeyboardKeyConfig) -> void:
logger.warn("Keyboard target not set, nowhere to send key input.")
return
var target = instance.context.target
logger.debug("Found target:", target)

# Get the input event based on mode shift
var event := key.input
Expand All @@ -377,12 +378,13 @@ func _handle_native(key: KeyboardKeyConfig) -> void:

# Get the character to send to the target
var character := String.chr(event.unicode)
logger.debug("Found character to send:", character)
if _mode_shift == MODE_SHIFT.ONE_SHOT:
set_mode_shift(MODE_SHIFT.OFF)

# If no character was found for the key, then it is a special character
# like shift, alt, etc.
if character == "":
if event.unicode == 0 or character == "":
_handle_native_action(key)
return

Expand Down