Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses and fixes a critical issue with the reentrancy guard implementation and extends its protection to all applicable state-changing functions across the contract.
closes #11
Changes Made
persistent()toinstance(). This ensures that if a guarded function panics, the lock is automatically cleared at the end of the transaction rather than permanently bricking the contract functions.reentrancy::enter(env)andreentrancy::exit(env)to the following unprotected state-changing functions:Error(Contract, #4)panic.Testing
wasm32-unknown-unknownenvironment, including the newly added mock reentrancy scenarios.