Repository navigation
feat: add admin-configurable transaction fees per accepted token - #60
Merged
codebestia merged 1 commit intoFeb 22, 2026
Merged
Conversation
codebestia
approved these changes
Feb 22, 2026
Tijesunimi004
pushed a commit
to Tijesunimi004/shade-stellar-contract
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLOSES #35
Description
Add comprehensive tests to verify the fee management functionality, ensuring admins can set fees for accepted tokens and that the contract enforces all validation rules (authorization, token acceptance, storage correctness, and event emission).
Type of Change
Related Issues
Fixes #
Changes Made
contracts/shade/src/tests/test_fees.rswith 5 test cases covering the full fee management surface area.test_feesmodule incontracts/shade/src/tests/mod.rs.Testing
test_set_fee_successget_feereturns the correct amount, and assertsFeeSetEventis emitted with correct token, fee, and timestamp.test_set_fee_unaccepted_tokenTokenNotAcceptedcontract error is returned.test_set_fee_unauthorizedNotAuthorizedcontract error is returned.test_update_feeget_feereflects the latest value.test_get_fee_default_zeroget_feereturns0for an accepted token with no fee explicitly set.Checklist
Screenshots (if applicable)
N/A
Additional Notes
Tests validate all three acceptance criteria: admin-only access enforcement, accepted-token validation, and correct storage/retrieval of fee values. The test structure follows the same patterns established in
test_accepted_tokens.rs, usingenv.as_contractfor event assertions andtry_*client methods for error-path tests.