fix(#353): kernel patch for CDM_Application::myMetaDataLookUpTable reentrancy SIGABRT (v1.15.11)#358
Merged
Merged
Conversation
…entrancy SIGABRT (v1.15.11) CDM_Application::myMetaDataLookUpTable is shared process-wide with no synchronization on its map accesses or on individual CDM_MetaData objects' myIsRetrieved/myDocument fields. Surfaced validating the #349 fix: a different document's destructor racing CDM_Document::SetMetaData()'s whole-table iteration (SIGABRT, confirmed by TSan: 1 race, 0 after fix). Fixes upstream via Open-Cascade-SAS/OCCT#1396 (repro) / #1397 (fix, CI green). CDM_MetaData::myDocumentVersion has the same unguarded-field shape but is not TSan-observed racing — flagged for a future pass, not filed separately. Rebased onto the concurrently-merged v1.15.10 docs-only TSan-gate release (#357); this ships as v1.15.11 instead. Wired the #353 barrier reproducer into Scripts/tsan-stress.sh's scenario matrix and removed its now-obsolete suppression from Scripts/tsan.supp (the real fix lands instead of masking it). Could not re-run the shared gate script's Libraries/occt-install-tsan end-to-end here — its build dir was configured by a different concurrent session's worktree (cross-worktree CMakeCache path mismatch); relied on the equivalent ad-hoc TSan protocol (occt-install-tsan349) documented in Scripts/repro/353-cdm-metadata-lookup-table/README.md instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
gsdali
force-pushed
the
fix/353-cdm-metadata-lookup-table-race
branch
from
July 23, 2026 02:02
6cdb7e9 to
237cc3b
Compare
gsdali
changed the title
Collaborator
Author
|
Rebased onto the concurrently-merged #357 (v1.15.10 docs-only TSan-gate release) — this now ships as v1.15.11 instead of v1.15.10 to avoid a version collision. Also wired the #353 barrier reproducer into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scripts/patches/0015-CDM_Application-metadata-lookup-table-mutex-353.patch) fixing the SIGABRT behind CDM_Application::myMetaDataLookUpTable unsynchronized (race surfaced by #349 fix) #353:CDM_Application::myMetaDataLookUpTableand theCDM_MetaDataobjects it hands out are shared process-wide with zero synchronization, surfaced while validating the Concurrent Save/SaveAs to the same format corrupts a shared, cached storage driver instance (SIGSEGV) #349 fix (v1.15.9).CDM_Applicationgets a mutex guarding the lookup table (threaded throughCDM_MetaData::LookUp()andCDM_Document::SetMetaData()'s iteration);CDM_MetaDatagets its own mutex guardingmyIsRetrieved/myDocument.CDM_MetaData::myDocumentVersionhas the same unguarded-field shape but wasn't TSan-observed racing — flagged in the writeup for a future pass, not filed as a separate issue.Test plan
Scripts/repro/349-ocaf-driver-reentrancy/occt_349_barrier.cppasScripts/repro/353-cdm-metadata-lookup-table/occt_353_barrier.cppswift test --filter OCAFSaveLoadBinaryTests/OCCTXCAFTestscleanswift test(4423 tests) clean🤖 Generated with Claude Code