Skip to content

fix: scope airdrop tier to RustChain-specific PRs, not GitHub-wide (fixes #8184) [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT] - #8192

Open
waterWang wants to merge 4 commits into
Scottcjn:mainfrom
waterWang:fix/airdrop-tier-scope
Open

fix: scope airdrop tier to RustChain-specific PRs, not GitHub-wide (fixes #8184) [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT]#8192
waterWang wants to merge 4 commits into
Scottcjn:mainfrom
waterWang:fix/airdrop-tier-scope

Conversation

@waterWang

Copy link
Copy Markdown
Contributor

Fix #8184: airdrop _determine_tier counts GitHub-wide activity

Problem

_determine_tier() in node/airdrop_v2.py queries GitHub's commit search API with:

q: author:{github_username} merged:true

This counts all merged PRs across all of GitHub — any established GitHub account reaches the CORE tier (200 wRTC) without ever contributing to RustChain.

Fix

Add repo:Scottcjn/Rustchain to the search query so only PRs merged into the RustChain repository are counted:

q: author:{github_username} repo:Scottcjn/Rustchain merged:true

Changes

  • 1 file changed: node/airdrop_v2.py (line 651)
  • 3 insertions, 3 deletions (whitespace normalization)

Testing

  • ✅ Python syntax check passed
  • ✅ Python compile check passed

…rrent mempool corruption (fixes Scottcjn#8176) [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT]
…ates (fixes Scottcjn#8095) [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT]
…ixes Scottcjn#8184) [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT]
@Scottcjn

Copy link
Copy Markdown
Owner

Holding this alongside #8190. This branch is stacked on it, so it carries the /p2p/gossip auth change as well as its own, and that change would break inter-node gossip as written. Details are in the review on #8190.

Nothing here is rejected. Once #8190 is revised, or once this is rebranched off current main so it carries only its own diff, I will review it on its own merits. main has moved a long way today, so a fresh branch is probably less work than untangling the stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

airdrop _determine_tier counts GitHub-wide activity, not RustChain contributions — any established account reaches CORE (200 wRTC)

2 participants