Skip to content

Fix detect-changed-benchmarks: handle shallow base fetch (no merge base) #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
May 30, 2026
Merged

Fix detect-changed-benchmarks: handle shallow base fetch (no merge base) #1595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/scripts/detect-changed-benchmarks.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,15 @@ source "${SCRIPT_DIR}/read-benchmark-config.sh"
if [[ "${GITHUB_EVENT_NAME}" == "pull_request" ]]; then
BASE_SHA="${GITHUB_BASE_REF}"
git fetch origin "${BASE_SHA}" --depth=1 2>/dev/null || true
CHANGED_FILES=$(git diff --name-only "origin/${BASE_SHA}...HEAD" -- 'benchmarks/')
CHANGED_FILES=$(git diff --name-only "origin/${BASE_SHA}...HEAD" -- 'benchmarks/' 2>/dev/null || true)
if [[ -z "${CHANGED_FILES}" ]]; then
# The three-dot range needs a merge base, which a shallow (--depth=1)
# fetch of the base lacks once master advances past the PR's branch
# point — git then aborts with "no merge base". PR builds check out
# refs/pull/N/merge, so HEAD~1 is the base tip; diffing against it
# yields exactly the PR's changes without requiring a merge base.
CHANGED_FILES=$(git diff --name-only HEAD~1 HEAD -- 'benchmarks/' 2>/dev/null || true)
fi
else
# Push event: compare against the last commit that was successfully published
# to SciMLBenchmarksOutput. This makes change detection cumulative — if a
Expand Down