Skip to content

Allow documented dependency reexports in QA#1520

Merged
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:codex/allow-catalyst-reexports
Jul 21, 2026
Merged

Allow documented dependency reexports in QA#1520
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:codex/allow-catalyst-reexports

Conversation

@ChrisRackauckas-Claude

@ChrisRackauckas-Claude ChrisRackauckas-Claude commented Jul 21, 2026

Copy link
Copy Markdown
Member

Ignore this PR until it is reviewed by @ChrisRackauckas.

Summary

  • Complete Document exported Catalyst APIs #1501's QA configuration by passing its existing DEPENDENCY_OWNED_PUBLIC_NAMES tuple to SciMLTesting's reexports_allow keyword.
  • Keep the public-reexport audit enabled while explicitly scoping the intentional dependency facade names.

Root cause

#1501 upgraded the QA environment to SciMLTesting 2.x and introduced an exact tuple of dependency-owned public names for the API-documentation checks. SciMLTesting 2.x also enables its public-reexport audit by default, but that same tuple was not passed to the audit, so the LTS/current/prerelease QA jobs rejected all 309 intentional facade reexports.

This does not set check_reexports = false and does not use a wildcard. Any future unapproved Catalyst-owned or dependency-owned reexport outside the computed tuple still fails the audit.

Validation

  • GROUP=QA julia +1.10 --project=. -e 'using Pkg; Pkg.test()': 14 passed, 4 broken; package tests passed.
  • GROUP=QA julia +1.12 --project=. -e 'using Pkg; Pkg.test()': 13 passed, 7 broken; package tests passed on 1.12.6.
  • GROUP=QA julia +1.13 --project=. -e 'using Pkg; Pkg.test()': 13 passed, 6 broken; package tests passed on 1.13.0-rc1.
  • Direct comparison with SciMLTesting.public_reexports(Catalyst): both sets contain 309 sorted, unique names; exact ordered equality is true with no missing or extra names.
  • Runic 1.7: test/qa/qa.jl passes --check --diff.
  • git diff --check: passed.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review July 21, 2026 21:18
@ChrisRackauckas
ChrisRackauckas merged commit f7164c2 into SciML:master Jul 21, 2026
18 of 22 checks passed
@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member Author

Post-hold hosted CI readback:

Thus the hosted lanes that reached the repaired public-reexport assertion passed, and no hosted failure points to this one-line QA fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants