Allow documented dependency reexports in QA#1520
Merged
ChrisRackauckas merged 1 commit intoJul 21, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
marked this pull request as ready for review
July 21, 2026 21:18
Member
Author
|
Post-hold hosted CI readback:
Thus the hosted lanes that reached the repaired public-reexport assertion passed, and no hosted failure points to this one-line QA fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore this PR until it is reviewed by @ChrisRackauckas.
Summary
DEPENDENCY_OWNED_PUBLIC_NAMEStuple to SciMLTesting'sreexports_allowkeyword.Root cause
#1501 upgraded the QA environment to SciMLTesting 2.x and introduced an exact tuple of dependency-owned public names for the API-documentation checks. SciMLTesting 2.x also enables its public-reexport audit by default, but that same tuple was not passed to the audit, so the LTS/current/prerelease QA jobs rejected all 309 intentional facade reexports.
This does not set
check_reexports = falseand does not use a wildcard. Any future unapproved Catalyst-owned or dependency-owned reexport outside the computed tuple still fails the audit.Validation
GROUP=QA julia +1.10 --project=. -e 'using Pkg; Pkg.test()': 14 passed, 4 broken; package tests passed.GROUP=QA julia +1.12 --project=. -e 'using Pkg; Pkg.test()': 13 passed, 7 broken; package tests passed on 1.12.6.GROUP=QA julia +1.13 --project=. -e 'using Pkg; Pkg.test()': 13 passed, 6 broken; package tests passed on 1.13.0-rc1.SciMLTesting.public_reexports(Catalyst): both sets contain 309 sorted, unique names; exact ordered equality is true with no missing or extra names.test/qa/qa.jlpasses--check --diff.git diff --check: passed.