Add cause-aware batch job requeue limits#209
Open
Yash0270 wants to merge 1 commit into
Open
Conversation
Add MaxNodeFailRequeue and MaxPreemptRequeue to bound node-failure and preemption/operator requeues independently from MaxBatchRequeue. Each cause keeps its own per-job counter. Jobs that exceed the configured limit are held with JobHeldMaxNodeFailRequeue or JobHeldMaxPreemptRequeue, while a limit of 0 disables the hold. scontrol release resets the counters so a released job gets a fresh allowance. The new config fields and job counters are packed behind the 26.11 protocol/state version guard. The change also updates config reporting, data parser coverage, Perl config bindings, reason-code docs, slurm.conf(5), the changelog, and ATF tests for the new limits and exemption cases. Changelog: Add MaxNodeFailRequeue and MaxPreemptRequeue to bound requeues by cause. Signed-off-by: Yash Gupta <guptayash0270@gmail.com>
4e85989 to
d3d8e8b
Compare
Author
It's due to new code landed in master. Once PR is reviewed, we can rename the test to the latest test number available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add cause-aware requeue limits for batch jobs so node failures and preemption/operator requeues can be bounded independently from
MaxBatchRequeue.MaxNodeFailRequeuedefaults to5and bounds node-failure requeues.MaxPreemptRequeuedefaults to0(unlimited) and bounds preemption/operator requeues.MaxBatchRequeuekeeps its existing launch/prolog failure behavior.JobHeldMaxNodeFailRequeueorJobHeldMaxPreemptRequeue;scontrol releaseresets the counters.This change was reviewed internally at Meta in Yash0270/slurm#4. We had originally planned to send a direct patch, but given the recent changes to
CONTRIBUTING.md, we are opening it as a pull request here instead.Target Release
Targets
master/ the next stable Slurm release because this addsslurm.confparameters plus protocol/state-file guarded job fields.Issue
Reported in SchedMD support ticket: https://support.schedmd.com/show_bug.cgi?id=24298
Implementation Notes
slurm.conf(5), andCHANGELOG/slurm-26.11.md.Memory Impact
Two
uint32_tcounters per job = 8 bytes per job (~0.74% of the ~1,074-bytejob_recordstruct).job_recordmemoryThe counters are controller-internal: packed under the
for_stateguard (state-save files only, not inscontrol show job/squeueRPC responses), so there is no network/protocol overhead.Testing
git diff --check origin/master...HEAD.testsuite/python/tests/test_105_11.pyfor node-failure holds, preemption/operator holds, user requeue andrequeueholdexemptions, counter independence,scontrol releasecounter reset, andMaxPreemptRequeue=0unlimited mode.slurmctld/slurmddaemons; result: 9/9 PASS.Contribution Notes
Signed-off-byandChangelog:trailers perCONTRIBUTING.md.Makefile.in,configure).