Repository navigation
minecraft/listener.go: Fix panic when listener closes during login - #533
Open
THEBOSS9345 wants to merge 1 commit into
Open
THEBOSS9345 wants to merge 1 commit into
THEBOSS9345 wants to merge 1 commit into
Conversation
…ener closes listen closed listener.incoming on exit, while handleConn could still be selecting on a send to it for a connection that just logged in. When both listener.close and listener.incoming were closed, select could pick the send and panic. incoming is no longer closed, and Accept waits on listener.close instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
my server crashed with send on closed channel in listener.go when the listener closes while a player is logging in. listen closes incoming while handleConn can still send to it. i stopped closing incoming and made Accept wait on close instead. tested on my server.