Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the dial context gets cancelled while the handshake is still running, DialContextNetwork returns the error but never closes the conn. listenConn keeps going in the background, finishes the login on its own and then gets stuck sending on readyForLogin/connected since nobody's reading anymore. RakNet keeps the session alive, so the client stays on the server until the process exits.
Fix is pretty small: close the conn with closeTransport when dialing fails after newConn (same helper the listener uses for LoginTimeout, so it can't hang on a blocked flush), buffer the two handshake channels so listenConn can't block once the dial returned, and cancel the dial's child context.
Easy to reproduce by cancelling the context during the handshake. Before the fix the server side conn stays open, after it it gets closed.