Skip to content

Fix positive repayments for negative balances #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twisti-dev merged 2 commits into from
May 14, 2026
Merged

Fix positive repayments for negative balances #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edcac8f
Fix minimum balance check for debt repayments
Keviro May 14, 2026
e3f2b6a
chore: bump version to 4.0.4
Keviro May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
kotlin.stdlib.default.dependency=false
org.gradle.parallel=true
version=4.0.3
version=4.0.4
org.gradle.jvmargs=-Xmx4G
3 changes: 2 additions & 1 deletion ...kotlin/dev/slne/surf/transaction/microservice/db/transaction/TransactionRepositoryImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,9 @@ class TransactionRepositoryImpl : TransactionRepository {

val transactionId = insertedTransactionRow[TransactionTable.id].value
val insertedReceiverId = insertedTransactionRow[TransactionTable.receiver]?.value
val reducesReceiverBalance = transaction.amount < BigDecimal.ZERO

if (insertedReceiverId != null && !transaction.ignoreMinimumAmount) {
if (insertedReceiverId != null && !transaction.ignoreMinimumAmount && reducesReceiverBalance) {
Comment thread
twisti-dev marked this conversation as resolved.
val balanceAfterTransaction = balanceDecimal0 {
(TransactionTable.currency eq currencyId.value) and
(TransactionTable.receiver eq insertedReceiverId)
Expand Down
Loading